2017-10-30 15:56:35

by Gabriele Paoloni

[permalink] [raw]
Subject: RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

Hi Randy

> -----Original Message-----
> From: Randy Dunlap [mailto:[email protected]]
> Sent: 27 October 2017 17:44
> To: Gabriele Paoloni; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; Linuxarm; [email protected];
> [email protected]; John Garry; xuwei (O); zhichang.yuan
> Subject: Re: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07
> with DT bindings
>
> On 10/27/17 09:11, Gabriele Paoloni wrote:
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 2408ea3..358eed3 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -64,6 +64,15 @@ config BRCMSTB_GISB_ARB
> > arbiter. This driver provides timeout and target abort error
> handling
> > and internal bus master decoding.
> >
> > +config HISILICON_LPC
> > + bool "Support for ISA I/O space on Hisilicon Hip0X"
> > + depends on (ARM64 && (ARCH_HISI || COMPILE_TEST))
> > + select LOGIC_PIO
> > + select INDIRECT_PIO
> > + help
> > + Driver needed for some legacy ISA devices attached to Low-Pin-
> Count
> > + on Hisilicon Hip0X SoC.
> > +
> > config IMX_WEIM
> > bool "Freescale EIM DRIVER"
> > depends on ARCH_MXC
>
> Hi,
>
> Why bool? why not tristate?

Well for the nature of our HW it would not make much sense to have the
LPC modular. Also you can see in patch 8 the LPC host is "translating"
the resources of its children before these are actually probed and this
is done by acpi_indirectio_scan_init() as part of the ACPI init process.

Thanks
Gab

>
> --
> ~Randy
?&ן6?o}߾???7?n??E?#??n???:?o~?M4?M{_???1? ???͸??u??8??5?e?f????m?l??ۣ?jנ??????