2006-01-12 21:28:48

by Eric Moore

Subject: [PATCH] - pci_ids - adding pci device id support for FC949ES

Adding support for new LSI Logic Fibre Channel controller.

Signed-off-by: Eric Moore <[email protected]>

--- b/include/linux/pci_ids.h 2006-01-11 19:04:18.000000000 -0700
+++ a/include/linux/pci_ids.h 2006-01-12 14:19:43.000000000 -0700
@@ -181,6 +181,7 @@
#define PCI_DEVICE_ID_LSI_FC929X 0x0626
#define PCI_DEVICE_ID_LSI_FC939X 0x0642
#define PCI_DEVICE_ID_LSI_FC949X 0x0640
+#define PCI_DEVICE_ID_LSI_FC949ES 0x0646
#define PCI_DEVICE_ID_LSI_FC919X 0x0628
#define PCI_DEVICE_ID_NCR_YELLOWFIN 0x0701
#define PCI_DEVICE_ID_LSI_61C102 0x0901

2006-01-13 08:03:47

by Andrew Morton

Subject: Re: [PATCH] - pci_ids - adding pci device id support for FC949ES

"Moore, Eric" <[email protected]> wrote:
>
> Adding support for new LSI Logic Fibre Channel controller.
>
> Signed-off-by: Eric Moore <[email protected]>
>
> --- b/include/linux/pci_ids.h 2006-01-11 19:04:18.000000000 -0700
> +++ a/include/linux/pci_ids.h 2006-01-12 14:19:43.000000000 -0700
> @@ -181,6 +181,7 @@
> #define PCI_DEVICE_ID_LSI_FC929X 0x0626
> #define PCI_DEVICE_ID_LSI_FC939X 0x0642
> #define PCI_DEVICE_ID_LSI_FC949X 0x0640
> +#define PCI_DEVICE_ID_LSI_FC949ES 0x0646
> #define PCI_DEVICE_ID_LSI_FC919X 0x0628
> #define PCI_DEVICE_ID_NCR_YELLOWFIN 0x0701
> #define PCI_DEVICE_ID_LSI_61C102 0x0901

That doesn't add support - it just adds the ID. We've apparently decided
not to keep IDs of devices which the kernel doesn't support.

Also, there's a plan to stop using pci_ids.h - PCI IDs are supposed to go
into a driver-private header file. I guess drivers/scsi/megaraid.h is an
example.

2006-01-13 18:10:14

by Christoph Hellwig

Subject: Re: [PATCH] - pci_ids - adding pci device id support for FC949ES

On Fri, Jan 13, 2006 at 12:03:23AM -0800, Andrew Morton wrote:
> > --- b/include/linux/pci_ids.h 2006-01-11 19:04:18.000000000 -0700
> > +++ a/include/linux/pci_ids.h 2006-01-12 14:19:43.000000000 -0700
> > @@ -181,6 +181,7 @@
> > #define PCI_DEVICE_ID_LSI_FC929X 0x0626
> > #define PCI_DEVICE_ID_LSI_FC939X 0x0642
> > #define PCI_DEVICE_ID_LSI_FC949X 0x0640
> > +#define PCI_DEVICE_ID_LSI_FC949ES 0x0646
> > #define PCI_DEVICE_ID_LSI_FC919X 0x0628
> > #define PCI_DEVICE_ID_NCR_YELLOWFIN 0x0701
> > #define PCI_DEVICE_ID_LSI_61C102 0x0901
>
> That doesn't add support - it just adds the ID. We've apparently decided
> not to keep IDs of devices which the kernel doesn't support.

There's a patch on linux-scsi that adds the actual support.

> Also, there's a plan to stop using pci_ids.h - PCI IDs are supposed to go
> into a driver-private header file. I guess drivers/scsi/megaraid.h is an
> example.

That's new to me. In either case a single driver should do one thing
consistantly, and fusion has tons of defines in pci_ids.h already.

2006-01-13 20:00:58

by Greg KH

Subject: Re: [PATCH] - pci_ids - adding pci device id support for FC949ES

On Fri, Jan 13, 2006 at 06:10:02PM +0000, Christoph Hellwig wrote:
> On Fri, Jan 13, 2006 at 12:03:23AM -0800, Andrew Morton wrote:
> > > --- b/include/linux/pci_ids.h 2006-01-11 19:04:18.000000000 -0700
> > > +++ a/include/linux/pci_ids.h 2006-01-12 14:19:43.000000000 -0700
> > > @@ -181,6 +181,7 @@
> > > #define PCI_DEVICE_ID_LSI_FC929X 0x0626
> > > #define PCI_DEVICE_ID_LSI_FC939X 0x0642
> > > #define PCI_DEVICE_ID_LSI_FC949X 0x0640
> > > +#define PCI_DEVICE_ID_LSI_FC949ES 0x0646
> > > #define PCI_DEVICE_ID_LSI_FC919X 0x0628
> > > #define PCI_DEVICE_ID_NCR_YELLOWFIN 0x0701
> > > #define PCI_DEVICE_ID_LSI_61C102 0x0901
> >
> > That doesn't add support - it just adds the ID. We've apparently decided
> > not to keep IDs of devices which the kernel doesn't support.
>
> There's a patch on linux-scsi that adds the actual support.

Then include this as part of that patch please. Or if you are going to
add ids to this file, at least CC: the PCI kernel maintainer so he knows
to add them. And also say that an already submitted patch needs it.

> > Also, there's a plan to stop using pci_ids.h - PCI IDs are supposed to go
> > into a driver-private header file. I guess drivers/scsi/megaraid.h is an
> > example.
>
> That's new to me. In either case a single driver should do one thing
> consistantly, and fusion has tons of defines in pci_ids.h already.

Yeah, for older drivers that already do this, I don't have a problem
adding it here. Then we can move all of the ids to the local file at
once in the future :)

thanks,

greg k-h