2006-03-14 00:52:59

by Eric Moore

[permalink] [raw]
Subject: [PATCH ] drivers/scsi/scsi.c - export reprobe

Request for exporting device_reprobe -
This is scsi wrapper portion.

---------------------------------------------------
Adding support for exposing hidden raid components
for sg interface. The sdev->no_uld_attach flag
will set set accordingly.

The sas module supports adding/removing raid
volumes using online storage management application
interface.

This patch was provided to me by Christoph Hellwig.

Signed-off-by: Eric Moore <[email protected]>


Attachments:
scsi_device_reprobe (1.13 kB)
scsi_device_reprobe

2006-03-14 15:36:22

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH ] drivers/scsi/scsi.c - export reprobe

On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> Request for exporting device_reprobe -
> This is scsi wrapper portion.

Is this even really needed? It's just a single pointer dereference...

thanks,

greg k-h

2006-03-14 16:08:36

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH ] drivers/scsi/scsi.c - export reprobe

On Tue, Mar 14, 2006 at 07:35:24AM -0800, Greg KH wrote:
> On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> > Request for exporting device_reprobe -
> > This is scsi wrapper portion.
>
> Is this even really needed? It's just a single pointer dereference...

We don't want SCSI LLDDs to know about implementations details like
sdev->sdev_gendev. Of course an inline or a macro could do this aswell.

2006-03-14 16:18:34

by Eric Moore

[permalink] [raw]
Subject: RE: [PATCH ] drivers/scsi/scsi.c - export reprobe

On Monday, March 13, 2006 5:53 PM, Eric Moore wrote:

>
> ---------------------------------------------------
> Adding support for exposing hidden raid components
> for sg interface. The sdev->no_uld_attach flag
> will set set accordingly.
>
> The sas module supports adding/removing raid
> volumes using online storage management application
> interface.
>
> This patch was provided to me by Christoph Hellwig.
>
> Signed-off-by: Eric Moore <[email protected]>


Here is repost of patch due to dos line endings.


Attachments:
scsi_device_reprobe (1.13 kB)
scsi_device_reprobe

2006-03-14 16:31:50

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [PATCH ] drivers/scsi/scsi.c - export reprobe

On Tue, 2006-03-14 at 16:08 +0000, Christoph Hellwig wrote:
> On Tue, Mar 14, 2006 at 07:35:24AM -0800, Greg KH wrote:
> > On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> > > Request for exporting device_reprobe -
> > > This is scsi wrapper portion.
> >
> > Is this even really needed? It's just a single pointer dereference...
>
> We don't want SCSI LLDDs to know about implementations details like
> sdev->sdev_gendev. Of course an inline or a macro could do this aswell.


this looks like a good candidate for an inline yes ;)

2006-03-14 22:02:29

by Eric Moore

[permalink] [raw]
Subject: RE: [PATCH ] drivers/scsi/scsi.c - export reprobe

On Monday, March 13, 2006 5:53 PM, I wrote:
>
> Request for exporting device_reprobe -
> This is scsi wrapper portion.
>
> ---------------------------------------------------
> Adding support for exposing hidden raid components
> for sg interface. The sdev->no_uld_attach flag
> will set set accordingly.
>
> The sas module supports adding/removing raid
> volumes using online storage management application
> interface.
>
> This patch was provided to me by Christoph Hellwig.
>
> Signed-off-by: Eric Moore <[email protected]>
>

repost ( hopefully not mangled).

Eric Moore


Attachments:
scsi_device_reprobe (1.11 kB)
scsi_device_reprobe