2012-08-07 04:37:24

by Arun MURTHY

[permalink] [raw]
Subject: RE: [PATCH 0/4] modem_shm: U8500 SHaRed Memory driver(SHRM)

> In u8500 platform the communication between the APE(Application
> Processor) and
> the modem subsystem(CMT) is by means of a shared DDR. The series of
> patches
> include a protocol called ShaRed Memory(SHRM) protocol for
> communicating
> between the APE and the CMT.
> Interrupt generation registers in CMT and PRCMU on APE side are used to
> support
> the shrm protocol.
>
> Arun Murthy (4):
> modem_shm: Add Modem Access Framework
> modem_shm: Register u8500 client for MAF
> modem_shm: u8500-shm: U8500 Shared Memory Driver
> Doc: Add u8500_shrm document
>
> Documentation/DocBook/Makefile | 2 +-
> Documentation/DocBook/shrm.tmpl | 125 ++
> Documentation/modem_shm/u8500_shrm.txt | 254 ++++
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/modem_shm/Kconfig | 22 +
> drivers/modem_shm/Makefile | 3 +
> drivers/modem_shm/modem_access.c | 419 ++++++
> drivers/modem_shm/modem_u8500.c | 96 ++
> drivers/modem_shm/u8500_shm/Kconfig | 43 +
> drivers/modem_shm/u8500_shm/Makefile | 7 +
> drivers/modem_shm/u8500_shm/shrm_char.c | 895 ++++++++++++
> drivers/modem_shm/u8500_shm/shrm_driver.c | 732 ++++++++++
> drivers/modem_shm/u8500_shm/shrm_fifo.c | 837 ++++++++++++
> drivers/modem_shm/u8500_shm/shrm_net.c | 312 +++++
> drivers/modem_shm/u8500_shm/shrm_protocol.c | 1590
> ++++++++++++++++++++++
> include/linux/modem_shm/modem.h | 64 +
> include/linux/modem_shm/modem_client.h | 55 +
> include/linux/modem_shm/u8500_shm/shrm.h | 23 +
> include/linux/modem_shm/u8500_shm/shrm_config.h | 114 ++
> include/linux/modem_shm/u8500_shm/shrm_driver.h | 225 +++
> include/linux/modem_shm/u8500_shm/shrm_ioctl.h | 43 +
> include/linux/modem_shm/u8500_shm/shrm_net.h | 46 +
> include/linux/modem_shm/u8500_shm/shrm_private.h | 183 +++
> 24 files changed, 6092 insertions(+), 1 deletions(-)
> create mode 100644 Documentation/DocBook/shrm.tmpl
> create mode 100644 Documentation/modem_shm/u8500_shrm.txt
> create mode 100644 drivers/modem_shm/Kconfig
> create mode 100644 drivers/modem_shm/Makefile
> create mode 100644 drivers/modem_shm/modem_access.c
> create mode 100644 drivers/modem_shm/modem_u8500.c
> create mode 100644 drivers/modem_shm/u8500_shm/Kconfig
> create mode 100644 drivers/modem_shm/u8500_shm/Makefile
> create mode 100644 drivers/modem_shm/u8500_shm/shrm_char.c
> create mode 100644 drivers/modem_shm/u8500_shm/shrm_driver.c
> create mode 100644 drivers/modem_shm/u8500_shm/shrm_fifo.c
> create mode 100644 drivers/modem_shm/u8500_shm/shrm_net.c
> create mode 100644 drivers/modem_shm/u8500_shm/shrm_protocol.c
> create mode 100644 include/linux/modem_shm/modem.h
> create mode 100644 include/linux/modem_shm/modem_client.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm_config.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm_driver.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm_ioctl.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm_net.h
> create mode 100644 include/linux/modem_shm/u8500_shm/shrm_private.h
>
> --
> 1.7.4.3


Any Comments?

Thanks and Regards,
Arun R Murthy
-------------


2012-08-07 06:37:08

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 0/4] modem_shm: U8500 SHaRed Memory driver(SHRM)

On Tue, Aug 7, 2012 at 6:36 AM, Arun MURTHY <[email protected]> wrote:

> Any Comments?

Since the modem is quite close to the networking stack, maybe it should be
cross-posted to the netdev list on next iteration:
http://vger.kernel.org/vger-lists.html#netdev

The code itself I think I've read so many times that I'm now unable to
see any remaining mistakes...

Yours,
Linus Walleij