2005-11-04 12:45:12

by Adrian Bunk

Subject: [-mm patch] drivers/char/tlclk.c: make two functions static

This patch makes two needlessly global functions static.


Signed-off-by: Adrian Bunk <[email protected]>

---

char/tlclk.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.14-rc5-mm1-full/drivers/char/tlclk.c.old 2005-11-04 11:18:45.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/char/tlclk.c 2005-11-04 11:19:21.000000000 +0100
@@ -225,8 +225,8 @@
return 0;
}

-ssize_t tlclk_read(struct file *filp, char __user *buf, size_t count,
- loff_t *f_pos)
+static ssize_t tlclk_read(struct file *filp, char __user *buf, size_t count,
+ loff_t *f_pos)
{
if (count < sizeof(struct tlclk_alarms))
return -EIO;
@@ -241,8 +241,8 @@
return sizeof(struct tlclk_alarms);
}

-ssize_t tlclk_write(struct file *filp, const char __user *buf, size_t count,
- loff_t *f_pos)
+static ssize_t tlclk_write(struct file *filp, const char __user *buf,
+ size_t count, loff_t *f_pos)
{
return 0;
}

2005-11-04 18:29:22

by Gross, Mark

Subject: RE: [-mm patch] drivers/char/tlclk.c: make two functions static

Thanks! I'll get these into the then next patch update!

I'm surprised those got missed.

--mgross

>-----Original Message-----
>From: Adrian Bunk [mailto:[email protected]]
>Sent: Friday, November 04, 2005 4:45 AM
>To: Gross, Mark
>Cc: [email protected]
>Subject: [-mm patch] drivers/char/tlclk.c: make two functions static
>
>This patch makes two needlessly global functions static.
>
>
>Signed-off-by: Adrian Bunk <[email protected]>
>
>---
>
> char/tlclk.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>--- linux-2.6.14-rc5-mm1-full/drivers/char/tlclk.c.old 2005-11-04
>11:18:45.000000000 +0100
>+++ linux-2.6.14-rc5-mm1-full/drivers/char/tlclk.c 2005-11-04
>11:19:21.000000000 +0100
>@@ -225,8 +225,8 @@
> return 0;
> }
>
>-ssize_t tlclk_read(struct file *filp, char __user *buf, size_t count,
>- loff_t *f_pos)
>+static ssize_t tlclk_read(struct file *filp, char __user *buf, size_t
count,
>+ loff_t *f_pos)
> {
> if (count < sizeof(struct tlclk_alarms))
> return -EIO;
>@@ -241,8 +241,8 @@
> return sizeof(struct tlclk_alarms);
> }
>
>-ssize_t tlclk_write(struct file *filp, const char __user *buf, size_t
count,
>- loff_t *f_pos)
>+static ssize_t tlclk_write(struct file *filp, const char __user *buf,
>+ size_t count, loff_t *f_pos)
> {
> return 0;
> }