2014-10-08 05:24:37

by Dexuan Cui

[permalink] [raw]
Subject: RE: [PATCH v3] Tools: hv: vssdaemon: ignore the EBUSY on multiple freezing the same partition

> -----Original Message-----
> From: devel [mailto:[email protected]] On Behalf
> Of Dexuan Cui
> Sent: Friday, September 26, 2014 12:52 PM
> To: [email protected]; [email protected]; driverdev-
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: Haiyang Zhang
> Subject: [PATCH v3] Tools: hv: vssdaemon: ignore the EBUSY on multiple
> freezing the same partition
>
> If a partition appears mounted more than once in /proc/mounts, vss_do_freeze()
> succeeds only for the first time and gets EBUSY (on freeze) or EINVAL (on
> thaw) for the second time. The patch ignores these to make the backup feature
> work.
>
> Also improved the error handling in case a freeze operation fails.
>
> Signed-off-by: Dexuan Cui <[email protected]>
> Reviewed-by: K. Y. Srinivasan <[email protected]>
> ---
>
> v2: Add "errno = 0;" before the ioctl()
> (Unnecessary and removed now since we remove syslog() in vss_do_freeze() in
> v3)
>
> v3: Remove the unsafe syslog() in vss_do_freeze(): that could write the disk.
> Thaw the filesystems in case the freezing operation fails.
> In main(), add syslog() when we check the return value of vss_operate().
>
> tools/hv/hv_vss_daemon.c | 48

Hi Greg,
Ping.

Thanks,
-- Dexuan