2023-10-10 05:48:08

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the mm tree

---

Hi all,

In commit

2a936ebfab06 ("mm/migrate: correct nr_failed in migrate_pages_sync()")

Fixes tag

Fixes: 2ef7dbb26990 ("migrate_pages: try migrate in batch asynchronously fi=

has these problem(s):

- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Please do not split Fixes tags over more than one line.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-10-10 15:43:30

by Zi Yan

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the mm tree

---

On 10 Oct 2023, at 1:47, Stephen Rothwell wrote:

> Hi all,
>
> In commit
>
> 2a936ebfab06 ("mm/migrate: correct nr_failed in migrate_pages_sync()")
>
> Fixes tag
>
> Fixes: 2ef7dbb26990 ("migrate_pages: try migrate in batch asynchronously fi=
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Please do not split Fixes tags over more than one line.

I have "transferEncoding=quoted-printable" set in my gitconfig, so git send-email
splits long lines by itself. Something wrong with that? In the email body,
it has "Content-Transfer-Encoding: quoted-printable" too.

--
Best Regards,
Yan, Zi

---

Attachments:

signature.asc (871.00 B)
OpenPGP digital signature