2007-05-16 06:54:07

by Su, Henry

Subject: +AFs-PATCH 4/4+AF0- Add the combined mode for ATI SB700

From: henry.su+AEA-amd.com
Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.

The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
but now it is not necessary for Linux since the kernel has supported AHCI.
Signed-off-by: Luugi Marsan +ADw-luugi.marsan+AEA-amd.com+AD4-
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci+AF8-ids.h linux-2.6.21.1/include/linux/pci+AF8-ids.h
--- linux-2.6.21.1.orig/include/linux/pci+AF8-ids.h 2007-05-16 13:28:54.405386000 +-0800
+-+-+- linux-2.6.21.1/include/linux/pci+AF8-ids.h 2007-05-16 13:45:29.936636000 +-0800
+AEAAQA- -371,6 +-371,9 +AEAAQA-
+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-SRAID 0x4381
+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-SMBUS 0x4385
+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-IDE 0x438c
+-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-SATA 0x4390
+-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-SMBUS 0x4395
+-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-IDE 0x439c

+ACM-define PCI+AF8-VENDOR+AF8-ID+AF8-VLSI 0x1004
+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-VLSI+AF8-82C592 0x0005

diff -Nur linux-2.6.21.1.orig/drivers/pci/quirks.c linux-2.6.21.1/drivers/pci/quirks.c
--- linux-2.6.21.1.orig/drivers/pci/quirks.c 2007-05-16 13:28:09.702261000 +-0800
+-+-+- linux-2.6.21.1/drivers/pci/quirks.c 2007-05-16 13:41:26.155386000 +-0800
+AEAAQA- -875,6 +-875,7 +AEAAQA-
+AH0-
+AH0-
DECLARE+AF8-PCI+AF8-FIXUP+AF8-HEADER(PCI+AF8-VENDOR+AF8-ID+AF8-ATI, PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-SATA, quirk+AF8-sb600+AF8-sata)+ADs-
+-DECLARE+AF8-PCI+AF8-FIXUP+AF8-HEADER(PCI+AF8-VENDOR+AF8-ID+AF8-ATI, PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-SATA, quirk+AF8-sb600+AF8-sata)+ADs-

/+ACo-
+ACo- Serverworks CSB5 IDE does not fully support native mode

2007-05-16 07:58:10

by Jeff Garzik

Subject: Re: [PATCH 4/4] Add the combined mode for ATI SB700

Henry Su wrote:
> From: [email protected]
> Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
>
> The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
> but now it is not necessary for Linux since the kernel has supported AHCI.

hmmmm. The patch looks OK, but your description seems to indicate that
the patch is not needed?

Jeff

2007-05-16 08:19:18

by Su, Henry

Subject: RE: +AFs-PATCH 4/4+AF0- Add the combined mode for ATI SB700

hi Jeff,
this patch is used to set the SATA controller back to AHCI mode when ATI SB700 is set
as combined mode or legacy IDE mode by BIOS, without this patch, just like ATI SB600,
the SB700 SATA device will fail in these two modes.

BRs,
henry

-----Original Message-----
From: Jeff Garzik +AFs-mailto:jeff+AEA-garzik.org+AF0-
Sent: Wednesday, May 16, 2007 3:58 PM
To: Henry Su
Cc: Bartlomiej Zolnierkiewicz+ADs- gregkh+AEA-suse.de+ADs- linux-kernel+AEA-vger.kernel.org+ADs- gmail+AF8-ati
Subject: Re: +AFs-PATCH 4/4+AF0- Add the combined mode for ATI SB700

Henry Su wrote:
+AD4- From: henry.su+AEA-amd.com
+AD4- Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
+AD4-
+AD4- The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
+AD4- but now it is not necessary for Linux since the kernel has supported AHCI.

hmmmm. The patch looks OK, but your description seems to indicate that
the patch is not needed?

Jeff