2018-10-23 14:19:28

by Waiman Long

Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work

The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi
page fault handler") converted efi_rts_work from an auto variable to a
global variable. However, when submitting the work, INIT_WORK_ONSTACK()
was still used causing the following complaint from debugobjects:

ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760,
but annotated.

Change the macro to just INIT_WORK() to eliminate the warning.

Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler")

Signed-off-by: Waiman Long <[email protected]>
---
drivers/firmware/efi/runtime-wrappers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
index a19d845..8903b9c 100644
--- a/drivers/firmware/efi/runtime-wrappers.c
+++ b/drivers/firmware/efi/runtime-wrappers.c
@@ -67,7 +67,7 @@
} \
\
init_completion(&efi_rts_work.efi_rts_comp); \
- INIT_WORK_ONSTACK(&efi_rts_work.work, efi_call_rts); \
+ INIT_WORK(&efi_rts_work.work, efi_call_rts); \
efi_rts_work.arg1 = _arg1; \
efi_rts_work.arg2 = _arg2; \
efi_rts_work.arg3 = _arg3; \
--
1.8.3.1

2018-10-23 17:04:18

by Prakhya, Sai Praneeth

Subject: RE: [PATCH] efi: Fix debugobjects warning on efi_rts_work

> -----Original Message-----
> From: Waiman Long [mailto:[email protected]]
> Sent: Tuesday, October 23, 2018 7:18 AM
> To: Ard Biesheuvel <[email protected]>
> Cc: [email protected]; [email protected]; Prakhya, Sai
> Praneeth <[email protected]>; Waiman Long
> <[email protected]>
> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>
> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler") converted efi_rts_work from an auto variable to a global variable.
> However, when submitting the work, INIT_WORK_ONSTACK() was still used
> causing the following complaint from debugobjects:
>
> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
> annotated.
>
> Change the macro to just INIT_WORK() to eliminate the warning.
>
> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler")

Thanks for fixing this :)
Looks good to me.

Regards,
Sai

2018-11-05 13:03:04

by Ard Biesheuvel

Subject: Re: [PATCH] efi: Fix debugobjects warning on efi_rts_work

On 23 October 2018 at 18:43, Prakhya, Sai Praneeth
<[email protected]> wrote:
>
>
>> -----Original Message-----
>> From: Waiman Long [mailto:[email protected]]
>> Sent: Tuesday, October 23, 2018 7:18 AM
>> To: Ard Biesheuvel <[email protected]>
>> Cc: [email protected]; [email protected]; Prakhya, Sai
>> Praneeth <[email protected]>; Waiman Long
>> <[email protected]>
>> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>>
>> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler") converted efi_rts_work from an auto variable to a global variable.
>> However, when submitting the work, INIT_WORK_ONSTACK() was still used
>> causing the following complaint from debugobjects:
>>
>> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
>> annotated.
>>
>> Change the macro to just INIT_WORK() to eliminate the warning.
>>
>> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler")
>
> Thanks for fixing this :)
> Looks good to me.
>
> Regards,
> Sai

Thanks

Queued in efi/urgent (with Sai's ack)