On 2020-10-27 04:46, Biwen Li wrote:
> From: Hou Zhiqiang <[email protected]>
>
> Add an new IRQ chip declaration for LS1043A and LS1088A
> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
> SCFG_INTPCR[31:0]
> of these SoCs is stored/read as SCFG_INTPCR[0:31] defaultly(bit
> reverse)
> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
>
> Signed-off-by: Hou Zhiqiang <[email protected]>
> Signed-off-by: Biwen Li <[email protected]>
You clearly couldn't be bothered to read what I wrote in my earlier
replies. I'm thus ignoring this series...
> ---
> Change in v2:
> - add despcription of bit reverse
> - update copyright
>
> drivers/irqchip/irq-ls-extirq.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-ls-extirq.c
> b/drivers/irqchip/irq-ls-extirq.c
> index 4d1179fed77c..9587bc2607fc 100644
> --- a/drivers/irqchip/irq-ls-extirq.c
> +++ b/drivers/irqchip/irq-ls-extirq.c
> @@ -1,5 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0
> -
> +/*
> + * Author: Rasmus Villemoes <[email protected]>
> + * Copyright 2020 NXP
... specially when you keep attributing someone else's copyright to NXP.
M.
--
Jazz is not dead. It just smells funny...
>
> On 2020-10-27 04:46, Biwen Li wrote:
> > From: Hou Zhiqiang <[email protected]>
> >
> > Add an new IRQ chip declaration for LS1043A and LS1088A
> > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
> > SCFG_INTPCR[31:0]
> > of these SoCs is stored/read as SCFG_INTPCR[0:31] defaultly(bit
> > reverse)
> > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
> >
> > Signed-off-by: Hou Zhiqiang <[email protected]>
> > Signed-off-by: Biwen Li <[email protected]>
>
> You clearly couldn't be bothered to read what I wrote in my earlier replies. I'm
> thus ignoring this series...
Okay, got it.
>
> > ---
> > Change in v2:
> > - add despcription of bit reverse
> > - update copyright
> >
> > drivers/irqchip/irq-ls-extirq.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/irq-ls-extirq.c
> > b/drivers/irqchip/irq-ls-extirq.c index 4d1179fed77c..9587bc2607fc
> > 100644
> > --- a/drivers/irqchip/irq-ls-extirq.c
> > +++ b/drivers/irqchip/irq-ls-extirq.c
> > @@ -1,5 +1,8 @@
> > // SPDX-License-Identifier: GPL-2.0
> > -
> > +/*
> > + * Author: Rasmus Villemoes <[email protected]>
> > + * Copyright 2020 NXP
>
> ... specially when you keep attributing someone else's copyright to NXP.
Then I don't know how to add the copyright, any suggestions?
>
> M.
> --
> Jazz is not dead. It just smells funny...
On 2020-10-27 10:35, Biwen Li (OSS) wrote:
>>
>> On 2020-10-27 04:46, Biwen Li wrote:
>> > From: Hou Zhiqiang <[email protected]>
>> >
>> > Add an new IRQ chip declaration for LS1043A and LS1088A
>> > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
>> > SCFG_INTPCR[31:0]
>> > of these SoCs is stored/read as SCFG_INTPCR[0:31] defaultly(bit
>> > reverse)
>> > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
>> >
>> > Signed-off-by: Hou Zhiqiang <[email protected]>
>> > Signed-off-by: Biwen Li <[email protected]>
>>
>> You clearly couldn't be bothered to read what I wrote in my earlier
>> replies. I'm
>> thus ignoring this series...
> Okay, got it.
>>
>> > ---
>> > Change in v2:
>> > - add despcription of bit reverse
>> > - update copyright
>> >
>> > drivers/irqchip/irq-ls-extirq.c | 10 +++++++++-
>> > 1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/irqchip/irq-ls-extirq.c
>> > b/drivers/irqchip/irq-ls-extirq.c index 4d1179fed77c..9587bc2607fc
>> > 100644
>> > --- a/drivers/irqchip/irq-ls-extirq.c
>> > +++ b/drivers/irqchip/irq-ls-extirq.c
>> > @@ -1,5 +1,8 @@
>> > // SPDX-License-Identifier: GPL-2.0
>> > -
>> > +/*
>> > + * Author: Rasmus Villemoes <[email protected]>
>> > + * Copyright 2020 NXP
>>
>> ... specially when you keep attributing someone else's copyright to
>> NXP.
> Then I don't know how to add the copyright, any suggestions?
Simple. You don't add anything. NXP's copyright doesn't apply to this
file before this patch, and your changes are so trivial that they don't
really warrant a mention. Furthermore, the git history already keeps
track
of who did what.
M.
--
Jazz is not dead. It just smells funny...
> >> On 2020-10-27 04:46, Biwen Li wrote:
> >> > From: Hou Zhiqiang <[email protected]>
> >> >
> >> > Add an new IRQ chip declaration for LS1043A and LS1088A
> >> > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
> >> > SCFG_INTPCR[31:0]
> >> > of these SoCs is stored/read as SCFG_INTPCR[0:31] defaultly(bit
> >> > reverse)
> >> > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
> >> >
> >> > Signed-off-by: Hou Zhiqiang <[email protected]>
> >> > Signed-off-by: Biwen Li <[email protected]>
> >>
> >> You clearly couldn't be bothered to read what I wrote in my earlier
> >> replies. I'm thus ignoring this series...
> > Okay, got it.
> >>
> >> > ---
> >> > Change in v2:
> >> > - add despcription of bit reverse
> >> > - update copyright
> >> >
> >> > drivers/irqchip/irq-ls-extirq.c | 10 +++++++++-
> >> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/irqchip/irq-ls-extirq.c
> >> > b/drivers/irqchip/irq-ls-extirq.c index 4d1179fed77c..9587bc2607fc
> >> > 100644
> >> > --- a/drivers/irqchip/irq-ls-extirq.c
> >> > +++ b/drivers/irqchip/irq-ls-extirq.c
> >> > @@ -1,5 +1,8 @@
> >> > // SPDX-License-Identifier: GPL-2.0
> >> > -
> >> > +/*
> >> > + * Author: Rasmus Villemoes <[email protected]>
> >> > + * Copyright 2020 NXP
> >>
> >> ... specially when you keep attributing someone else's copyright to
> >> NXP.
> > Then I don't know how to add the copyright, any suggestions?
>
> Simple. You don't add anything. NXP's copyright doesn't apply to this file
> before this patch, and your changes are so trivial that they don't really warrant
> a mention. Furthermore, the git history already keeps track of who did what.
Okay, got it. Thanks.
>
> M.
> --
> Jazz is not dead. It just smells funny...