The patches enable UHCI driver in AST2600 and also enable
USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
arch/arm/configs/aspeed_g5_defconfig | 1 +
drivers/usb/host/uhci-platform.c | 3 ++-
3 files changed, 11 insertions(+), 1 deletion(-)
--
2.17.1
Enable UHCI driver in aspeed_g5_defconfig.
Signed-off-by: Ryan Chen <[email protected]>
---
arch/arm/configs/aspeed_g5_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
index 2bacd8c90f4b..a57009d1a3b8 100644
--- a/arch/arm/configs/aspeed_g5_defconfig
+++ b/arch/arm/configs/aspeed_g5_defconfig
@@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_ROOT_HUB_TT=y
CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_UHCI_HCD=y
CONFIG_USB_GADGET=y
CONFIG_USB_ASPEED_VHUB=y
CONFIG_USB_CONFIGFS=y
--
2.17.1
Add support for AST2600 SOC UHCI driver.
Signed-off-by: Ryan Chen <[email protected]>
---
drivers/usb/host/uhci-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
index 70dbd95c3f06..fa40fe125c2a 100644
--- a/drivers/usb/host/uhci-platform.c
+++ b/drivers/usb/host/uhci-platform.c
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
num_ports);
}
if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
- of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+ of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+ of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
uhci->is_aspeed = 1;
dev_info(&pdev->dev,
"Enabled Aspeed implementation workarounds\n");
--
2.17.1
On Wed, Sep 30, 2020 at 12:08:21PM +0800, Ryan Chen wrote:
> Enable UHCI driver in aspeed_g5_defconfig.
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Tao Ren <[email protected]>
On Wed, Sep 30, 2020 at 12:08:22PM +0800, Ryan Chen wrote:
> Add support for AST2600 SOC UHCI driver.
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Tao Ren <[email protected]>
Hello Joel,
Have you take time review this patches ?
Ryan Chen
Tel : 886-3-5751185 ext:8857
> -----Original Message-----
> From: Ryan Chen <[email protected]>
> Sent: Wednesday, September 30, 2020 12:08 PM
> To: Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; BMC-SW
> <[email protected]>
> Cc: Ryan Chen <[email protected]>
> Subject: [PATCH 0/3] Enable USB host for AST2600
>
> The patches enable UHCI driver in AST2600 and also enable USB host in
> aspeed-ast2600-evb.dts.
>
> Ryan Chen (3):
> configs: aspeed: enable UHCI driver in defconfig
> usb: host: add uhci compatible support for ast2600-uhci
> ARM: dts: add ehci uhci enable in evb dts
>
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
> arch/arm/configs/aspeed_g5_defconfig | 1 +
> drivers/usb/host/uhci-platform.c | 3 ++-
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
On Wed, 30 Sep 2020 at 04:08, Ryan Chen <[email protected]> wrote:
>
> Enable UHCI driver in aspeed_g5_defconfig.
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
> ---
> arch/arm/configs/aspeed_g5_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
> index 2bacd8c90f4b..a57009d1a3b8 100644
> --- a/arch/arm/configs/aspeed_g5_defconfig
> +++ b/arch/arm/configs/aspeed_g5_defconfig
> @@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_ROOT_HUB_TT=y
> CONFIG_USB_EHCI_HCD_PLATFORM=y
> +CONFIG_USB_UHCI_HCD=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_ASPEED_VHUB=y
> CONFIG_USB_CONFIGFS=y
> --
> 2.17.1
>
On Wed, 30 Sep 2020 at 04:08, Ryan Chen <[email protected]> wrote:
>
> Add support for AST2600 SOC UHCI driver.
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
USB maintainers, can you please take this patch (2/3)? I will take the
others in this series through the aspeed tree.
Cheers,
Joel
> ---
> drivers/usb/host/uhci-platform.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index 70dbd95c3f06..fa40fe125c2a 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> num_ports);
> }
> if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
> - of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
> + of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
> + of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
> uhci->is_aspeed = 1;
> dev_info(&pdev->dev,
> "Enabled Aspeed implementation workarounds\n");
> --
> 2.17.1
>
On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote:
> On Wed, 30 Sep 2020 at 04:08, Ryan Chen <[email protected]> wrote:
> >
> > Add support for AST2600 SOC UHCI driver.
> >
> > Signed-off-by: Ryan Chen <[email protected]>
>
> Reviewed-by: Joel Stanley <[email protected]>
>
> USB maintainers, can you please take this patch (2/3)? I will take the
> others in this series through the aspeed tree.
>
> Cheers,
>
> Joel
>
>
> > ---
> > drivers/usb/host/uhci-platform.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> > index 70dbd95c3f06..fa40fe125c2a 100644
> > --- a/drivers/usb/host/uhci-platform.c
> > +++ b/drivers/usb/host/uhci-platform.c
> > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> > num_ports);
> > }
> > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
> > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
> > + of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
> > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
> > uhci->is_aspeed = 1;
> > dev_info(&pdev->dev,
> > "Enabled Aspeed implementation workarounds\n");
> > --
> > 2.17.1
> >
The indentation of the continuation lines isn't good, because the
continued parts are aligned with the lines in the conditional block.
They should be visually distinct. Either align with the "of_device..."
at the start or indent by two extra tab stops.
Once this is fixed, you can add:
Acked-by: Alan Stern <[email protected]>
Alan Stern