2002-02-10 12:26:16

by Alex Scheele

[permalink] [raw]
Subject: [patch][2.5.4-dj4] cleanup, use strsep in tridentfb.c

Hi,

This patch changes strtok() use to strsep().
Strtok() isn't SMP/thread safe. strsep is considered safer.


--
Alex ([email protected])


-------------------------- cut here -------------------------
diff -Nru linux-2.5.3-dj4/drivers/video/tridentfb.c linux/drivers/video/tridentfb.c
--- linux-2.5.3-dj4/drivers/video/tridentfb.c Sat Feb 9 21:03:01 2002
+++ linux/drivers/video/tridentfb.c Sat Feb 9 21:03:01 2002
@@ -1259,8 +1259,8 @@
char * opt;
if (!options || !*options)
return 0;
- for(opt = strtok(options,",");opt;opt = strtok(NULL,",")){
- if (!opt) continue;
+ while((opt=strsep(&options,",")) != NULL) {
+ if (!*opt) continue;
if (!strncmp(opt,"noaccel",7))
noaccel = 1;
else if (!strncmp(opt,"accel",5))