2021-12-08 18:41:59

by David Heidelberg

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: reset: document deprecated HiSilicon property

Documenting deprecated property prevents dt-schema validation errors.

Signed-off-by: David Heidelberg <[email protected]>
---
v2:
- document deprecated property instead of changing hi36[67]0.dtsi

.../devicetree/bindings/reset/hisilicon,hi3660-reset.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
index b0c41ab1a746..cdfcf32c53fa 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
@@ -24,6 +24,11 @@ properties:
- const: hisilicon,hi3670-reset
- const: hisilicon,hi3660-reset

+ hisi,rst-syscon:
+ deprecated: true
+ description: phandle of the reset's syscon, use hisilicon,rst-syscon instead
+ $ref: /schemas/types.yaml#/definitions/phandle
+
hisilicon,rst-syscon:
description: phandle of the reset's syscon.
$ref: /schemas/types.yaml#/definitions/phandle
--
2.33.0



2021-12-15 09:52:34

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: reset: document deprecated HiSilicon property

Hi David,

On Wed, 2021-12-08 at 19:41 +0100, David Heidelberg wrote:
> Documenting deprecated property prevents dt-schema validation errors.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> v2:
>  - document deprecated property instead of changing hi36[67]0.dtsi

Sorry if I'm missing context, I haven't seen the v1 for this. Is this
really what we want? I would have expected the deprecated usage in the
.dtsi files to be replaced.

regards
Philipp

2021-12-15 10:03:31

by David Heidelberg

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: reset: document deprecated HiSilicon property

Hi Philipp,

In "[PATCH] arm64: dts: hisilicon: update deprecated property name"
(v1) I was reffered to
https://www.spinics.net/lists/arm-kernel/msg887577.html
David

On Wed, Dec 15 2021 at 10:52:15 +0100, Philipp Zabel
<[email protected]> wrote:
> Hi David,
>
> On Wed, 2021-12-08 at 19:41 +0100, David Heidelberg wrote:
>> Documenting deprecated property prevents dt-schema validation
>> errors.
>>
>> Signed-off-by: David Heidelberg <[email protected]>
>> ---
>> v2:
>> - document deprecated property instead of changing hi36[67]0.dtsi
>
> Sorry if I'm missing context, I haven't seen the v1 for this. Is this
> really what we want? I would have expected the deprecated usage in the
> .dtsi files to be replaced.
>
> regards
> Philipp



2021-12-15 12:14:36

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: reset: document deprecated HiSilicon property

On Wed, 2021-12-15 at 11:03 +0100, David Heidelberg wrote:
> Hi Philipp,
>
> In "[PATCH] arm64: dts: hisilicon: update deprecated property name"
> (v1) I was reffered to
> https://www.spinics.net/lists/arm-kernel/msg887577.html
> David

Thank you, I'll pick this up into reset/next.

regards
Philipp

2021-12-15 16:48:04

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: reset: document deprecated HiSilicon property

On Wed, 08 Dec 2021 19:41:49 +0100, David Heidelberg wrote:
> Documenting deprecated property prevents dt-schema validation errors.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> v2:
> - document deprecated property instead of changing hi36[67]0.dtsi
>
> .../devicetree/bindings/reset/hisilicon,hi3660-reset.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>

Acked-by: Rob Herring <[email protected]>