2023-08-30 20:27:05

by Martin Botka

[permalink] [raw]
Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions

Got it.

Cheers,
Martin

On Wed, Aug 30 2023 at 04:43:12 PM +01:00:00, Sudeep Holla
<[email protected]> wrote:
> On Wed, Aug 30, 2023 at 04:19:23PM +0200, Martin Botka wrote:
>> The patches using this are still WIP but the basic point is that
>> H616 has 2
>> die revisions (And those have
>> couple of other versions themselves) that require different uV and
>> some
>> frequencies are blacklisted on those
>> versions.
>>
>> The driver is using these functions to read the revision (Not the
>> version.
>> It just looked like the logical
>> thing to export both and Andre confirmed. We can ofc drop the
>> version symbol
>> export if need be) and reads
>> trough the OPP table and selects the supported frequencies and uV
>> for the
>> chip its running on :)
>>
>> I will try to get the cpufreq patches in order in the upcoming days
>> and I
>> will Cc you in those as well +
>> post a link to them in this thread :)
>>
>
> For simplicity, just make this patch part of the series that adds
> cpufreq
> support on this platform/soc. Cross referencing won't give any more
> confidence
> that the user is also getting merged at the same time as this patch.
>
> --
> Regards,
> Sudeep