2024-01-30 23:32:53

by Corona, Ernesto

[permalink] [raw]
Subject: [PATCH 30 5/7] Add JTAG core driver ioctl number

JTAG class driver provide infrastructure to support hardware/software JTAG platform drivers. It provide user layer API interface for flashing and debugging external devices which equipped with JTAG interface using standard transactions.

Driver exposes set of IOCTL to user space for:
- XFER:
SIR (Scan Instruction Register, IEEE 1149.1 Data Register scan);
SDR (Scan Data Register, IEEE 1149.1 Instruction Register scan);
- GIOCSTATUS read the current TAPC state of the JTAG controller
- SIOCSTATE Forces the JTAG TAPC to go into a particular state.
- SIOCFREQ/GIOCFREQ for setting and reading JTAG frequency.
- IOCBITBANG for low level control of JTAG signals.

Signed-off-by: Oleksandr Shamray <[email protected]>
Signed-off-by: Ernesto Corona <[email protected]>
Signed-off-by: Omar Castro <[email protected]>
Acked-by: Philippe Ombredanne <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Gustavo Pimentel <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Cc: Kishon Vijay Abraham I <[email protected]>
Cc: Darrick J. Wong <[email protected]>
Cc: Bryant G. Ly <[email protected]>
Cc: Eric Sandeen <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Tomohiro Kusumi <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Eric Biggers <[email protected]>
Cc: Steven Filary <[email protected]>
Cc: Jiri Pirko <[email protected]>
Cc: Vadim Pasternak <[email protected]>
Cc: Amithash Prasad <[email protected]>
Cc: Patrick Williams <[email protected]>
Cc: Luke Chen <[email protected]>
Cc: Billy Tsai <[email protected]>
Cc: Rgrs <[email protected]>

v29->v30
Update Ioctl number to 0xB9 due conflicts.
Change email contact.

v28->v29
Move ioctl number to userspace-api/ioctl/ioctl-number.rst
---
Documentation/userspace-api/ioctl/ioctl-number.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
index 457e16f06e04..cf602aa3a853 100644
--- a/Documentation/userspace-api/ioctl/ioctl-number.rst
+++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
@@ -358,6 +358,8 @@ Code Seq# Include File Comments
0xB6 all linux/fpga-dfl.h
0xB7 all uapi/linux/remoteproc_cdev.h <mailto:[email protected]>
0xB7 all uapi/linux/nsfs.h <mailto:Andrei Vagin <[email protected]>>
+0xB9 00-0F linux/jtag.h JTAG driver
+ <mailto:[email protected]>
0xC0 00-0F linux/usb/iowarrior.h
0xCA 00-0F uapi/misc/cxl.h
0xCA 10-2F uapi/misc/ocxl.h
--
2.25.1


2024-01-30 23:39:22

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 30 5/7] Add JTAG core driver ioctl number

On Tue, Jan 30, 2024 at 11:32:14PM +0000, Corona, Ernesto wrote:
> JTAG class driver provide infrastructure to support hardware/software JTAG platform drivers. It provide user layer API interface for flashing and debugging external devices which equipped with JTAG interface using standard transactions.

Please properly wrap your changelog text, didn't checkpatch warn of
this?

> Driver exposes set of IOCTL to user space for:
> - XFER:
> SIR (Scan Instruction Register, IEEE 1149.1 Data Register scan);
> SDR (Scan Data Register, IEEE 1149.1 Instruction Register scan);
> - GIOCSTATUS read the current TAPC state of the JTAG controller
> - SIOCSTATE Forces the JTAG TAPC to go into a particular state.
> - SIOCFREQ/GIOCFREQ for setting and reading JTAG frequency.
> - IOCBITBANG for low level control of JTAG signals.

Where are these ioctls implemented? THat has nothing to do with this
patch itself, right?

And what's the "30" in the patch number above for?

confused,

greg k-h