2024-01-30 23:33:01

by Corona, Ernesto

Subject: [PATCH 30 7/7] Add AST2500 and AST2600 JTAG device in DTS

Adding aspeed jtag device to device tree

Signed-off-by: Ernesto Corona <[email protected]>
Signed-off-by: Omar Castro <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Cc: Jiri Pirko <[email protected]>
Cc: Vadim Pasternak <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Nicolas Ferre <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Lukas Bulwahn <[email protected]>
Cc: Steven Filary <[email protected]>
Cc: Amithash Prasad <[email protected]>
Cc: Patrick Williams <[email protected]>
Cc: Luke Chen <[email protected]>
Cc: Billy Tsai <[email protected]>
---
arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 9 +++++++++
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 ++++++++++++++++++++
2 files changed, 29 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
index 04f98d1dbb97..3610aa758702 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
@@ -445,6 +445,15 @@ vuart: serial@1e787000 {
status = "disabled";
};

+ jtag: jtag@1e6e4000 {
+ compatible = "aspeed,ast2500-jtag";
+ reg = <0x1e6e4000 0x1c>;
+ clocks = <&syscon ASPEED_CLK_APB>;
+ resets = <&syscon ASPEED_RESET_JTAG_MASTER>;
+ interrupts = <43>;
+ status = "disabled";
+ };
+
lpc: lpc@1e789000 {
compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon";
reg = <0x1e789000 0x1000>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
index c4d1faade8be..d5353f728689 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
@@ -411,6 +411,26 @@ xdma: xdma@1e6e7000 {
status = "disabled";
};

+ jtag0: jtag@1e6e4000 {
+ compatible = "aspeed,ast2600-jtag";
+ reg = <0x1e6e4000 0x40>;
+ clocks = <&syscon ASPEED_CLK_APB1>;
+ resets = <&syscon ASPEED_RESET_JTAG_MASTER>;
+ interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
+ jtag1: jtag@1e6e4100 {
+ compatible = "aspeed,ast2600-jtag";
+ reg = <0x1e6e4100 0x40>;
+ clocks = <&syscon ASPEED_CLK_APB1>;
+ resets = <&syscon ASPEED_RESET_JTAG_MASTER2>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_jtagm_default>;
+ status = "disabled";
+ };
+
adc0: adc@1e6e9000 {
compatible = "aspeed,ast2600-adc0";
reg = <0x1e6e9000 0x100>;
--
2.25.1

2024-02-01 12:05:11

by Andy Shevchenko

Subject: Re: [PATCH 30 7/7] Add AST2500 and AST2600 JTAG device in DTS

On Thu, Feb 01, 2024 at 01:32:11PM +0200, '[email protected]' wrote:
> On Tue, Jan 30, 2024 at 11:32:48PM +0000, Corona, Ernesto wrote:
> > Adding aspeed jtag device to device tree
> >
> > Signed-off-by: Ernesto Corona <[email protected]>
> > Signed-off-by: Omar Castro <[email protected]>
> > Acked-by: Arnd Bergmann <[email protected]>
>
> First of all, please use --thread to git-format-patch when preparing the
> series.
>
> > Cc: Jiri Pirko <[email protected]>
> > Cc: Vadim Pasternak <[email protected]>
> > Cc: Mauro Carvalho Chehab <[email protected]>
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Cc: David S. Miller <[email protected]>
> > Cc: Nicolas Ferre <[email protected]>
> > Cc: Rob Herring <[email protected]>
> > Cc: Andy Shevchenko <[email protected]>
> > Cc: Lukas Bulwahn <[email protected]>
> > Cc: Steven Filary <[email protected]>
> > Cc: Amithash Prasad <[email protected]>
> > Cc: Patrick Williams <[email protected]>
> > Cc: Luke Chen <[email protected]>
> > Cc: Billy Tsai <[email protected]>
>
> Second, please avoid flooding commit message with unneeded details, i.e. move
> these Cc:s to...
>
> > ---
> ...the after this cutter line.

Also, you may use standard versioning pattern by using -v31 next time for
git-format-patch (31 is an example, you may choose the correct version).

--
With Best Regards,
Andy Shevchenko

2024-02-01 12:06:00

by Andy Shevchenko

Subject: Re: [PATCH 30 7/7] Add AST2500 and AST2600 JTAG device in DTS

On Tue, Jan 30, 2024 at 11:32:48PM +0000, Corona, Ernesto wrote:
> Adding aspeed jtag device to device tree
>
> Signed-off-by: Ernesto Corona <[email protected]>
> Signed-off-by: Omar Castro <[email protected]>
> Acked-by: Arnd Bergmann <[email protected]>

First of all, please use --thread to git-format-patch when preparing the
series.

> Cc: Jiri Pirko <[email protected]>
> Cc: Vadim Pasternak <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Nicolas Ferre <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Lukas Bulwahn <[email protected]>
> Cc: Steven Filary <[email protected]>
> Cc: Amithash Prasad <[email protected]>
> Cc: Patrick Williams <[email protected]>
> Cc: Luke Chen <[email protected]>
> Cc: Billy Tsai <[email protected]>

Second, please avoid flooding commit message with unneeded details, i.e. move
these Cc:s to...

> ---
..the after this cutter line.

--
With Best Regards,
Andy Shevchenko