2019-12-04 01:16:02

by Bean Huo

Subject: [PATCH RESEND] scsi: ufs: delete unused structure filed tc

From: Bean Huo <[email protected]>

Delete unused structure field tc in structure utp_upiu_req, since no person
uses it for task management.

Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")
Signed-off-by: Bean Huo <[email protected]>
---
include/uapi/scsi/scsi_bsg_ufs.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/uapi/scsi/scsi_bsg_ufs.h b/include/uapi/scsi/scsi_bsg_ufs.h
index 9988db6ad244..d55f2176dfd4 100644
--- a/include/uapi/scsi/scsi_bsg_ufs.h
+++ b/include/uapi/scsi/scsi_bsg_ufs.h
@@ -68,14 +68,13 @@ struct utp_upiu_cmd {
* @header:UPIU header structure DW-0 to DW-2
* @sc: fields structure for scsi command DW-3 to DW-7
* @qr: fields structure for query request DW-3 to DW-7
+ * @uc: use utp_upiu_query to host the 4 dwords of uic command
*/
struct utp_upiu_req {
struct utp_upiu_header header;
union {
struct utp_upiu_cmd sc;
struct utp_upiu_query qr;
- struct utp_upiu_query tr;
- /* use utp_upiu_query to host the 4 dwords of uic command */
struct utp_upiu_query uc;
};
};
--
2.17.1

2019-12-04 07:13:56

by Avri Altman

Subject: RE: [PATCH RESEND] scsi: ufs: delete unused structure filed tc

> From: Bean Huo <[email protected]>
>
> Delete unused structure field tc in structure utp_upiu_req, since no person uses
Typo tc -> tr

Thanks,
Avri


> it for task management.
>
> Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")
> Signed-off-by: Bean Huo <[email protected]>
> ---
> include/uapi/scsi/scsi_bsg_ufs.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/uapi/scsi/scsi_bsg_ufs.h b/include/uapi/scsi/scsi_bsg_ufs.h
> index 9988db6ad244..d55f2176dfd4 100644
> --- a/include/uapi/scsi/scsi_bsg_ufs.h
> +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> @@ -68,14 +68,13 @@ struct utp_upiu_cmd {
> * @header:UPIU header structure DW-0 to DW-2
> * @sc: fields structure for scsi command DW-3 to DW-7
> * @qr: fields structure for query request DW-3 to DW-7
> + * @uc: use utp_upiu_query to host the 4 dwords of uic command
> */
> struct utp_upiu_req {
> struct utp_upiu_header header;
> union {
> struct utp_upiu_cmd sc;
> struct utp_upiu_query qr;
> - struct utp_upiu_query tr;
> - /* use utp_upiu_query to host the 4 dwords of uic command */
> struct utp_upiu_query uc;
> };
> };
> --
> 2.17.1