2019-11-26 07:00:36

by Can Guo

Subject: [PATCH v3 2/4] scsi: ufs: Update VCCQ2 and VCCQ min/max voltage hard codes

From: Can Guo <[email protected]>

Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ
voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to
make sure they work in a safe range compliant for ver 1.0/1.1/2.0/2.1/3.0
UFS devices.

Signed-off-by: Can Guo <[email protected]>
---
drivers/scsi/ufs/ufs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 385bac8..0ded95e 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -500,9 +500,9 @@ struct ufs_query_res {
#define UFS_VREG_VCC_MAX_UV 3600000 /* uV */
#define UFS_VREG_VCC_1P8_MIN_UV 1700000 /* uV */
#define UFS_VREG_VCC_1P8_MAX_UV 1950000 /* uV */
-#define UFS_VREG_VCCQ_MIN_UV 1100000 /* uV */
-#define UFS_VREG_VCCQ_MAX_UV 1300000 /* uV */
-#define UFS_VREG_VCCQ2_MIN_UV 1650000 /* uV */
+#define UFS_VREG_VCCQ_MIN_UV 1140000 /* uV */
+#define UFS_VREG_VCCQ_MAX_UV 1260000 /* uV */
+#define UFS_VREG_VCCQ2_MIN_UV 1700000 /* uV */
#define UFS_VREG_VCCQ2_MAX_UV 1950000 /* uV */

/*
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2019-11-26 07:42:36

by Avri Altman

Subject: RE: [PATCH v3 2/4] scsi: ufs: Update VCCQ2 and VCCQ min/max voltage hard codes

>
> From: Can Guo <[email protected]>
>
> Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ
> voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to make
> sure they work in a safe range compliant for ver 1.0/1.1/2.0/2.1/3.0 UFS
> devices.
>
> Signed-off-by: Can Guo <[email protected]>
Reviewed-by Avri Altman <[email protected]>

2019-11-27 12:44:25

by Bean Huo (beanhuo)

Subject: RE: [EXT] RE: [PATCH v3 2/4] scsi: ufs: Update VCCQ2 and VCCQ min/max voltage hard codes

> > voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to
> > make sure they work in a safe range compliant for ver
> > 1.0/1.1/2.0/2.1/3.0 UFS devices.
> >
> > Signed-off-by: Can Guo <[email protected]>
> Reviewed-by Avri Altman <[email protected]>
Hi, Avri
Your review tag string missed a colon, which results in cannot mark R in patchwork.


Reviewed-by: Bean Huo <[email protected]>

2019-12-02 07:46:20

by Avri Altman

Subject: RE: [PATCH v3 2/4] scsi: ufs: Update VCCQ2 and VCCQ min/max voltage hard codes

> >> Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the
> >> VCCQ voltage range is 1.14v ~ 1.26v. Update their hard codes
> >> accordingly to make sure they work in a safe range compliant for ver
> >> 1.0/1.1/2.0/2.1/3.0 UFS devices.
> >>
> >> Signed-off-by: Can Guo <[email protected]>
Reviewed-by: Avri Altman <[email protected]>