2019-10-22 23:51:12

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tags need some work in the tip tree

---

Hi all,

n commit

6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")

Fixes tag

Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

In commit

db633a4e0e6e ("x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL, for clang/llvm")

Fixes tag

Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2019-10-22 23:52:05

by Thomas Hellstrom

[permalink] [raw]

Subject: Re: linux-next: Fixes tags need some work in the tip tree

---

On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> Hi all,
>
> n commit
>
> 6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
>
> Fixes tag
>
> Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

The cited subject is missing a leading "x86/vmware:". Ingo, please let
me know if you want me to respin those.

Thanks,

Thomas

2019-10-23 10:19:06

by Ingo Molnar

[permalink] [raw]

Subject: Re: linux-next: Fixes tags need some work in the tip tree

---

* Thomas Hellstrom <[email protected]> wrote:

> On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > n commit
> >
> > 6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
> >
> > Fixes tag
> >
> > Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")
>
> The cited subject is missing a leading "x86/vmware:". Ingo, please let
> me know if you want me to respin those.

Those who are picking it up for a backport will go by the sha1, while
humans reading it are fine without the prefix, I think this is OK as-is.

Thanks,

Ingo