2020-11-20 18:32:44

by Gustavo A. R. Silva

Subject: [PATCH 035/141] IB/qedr: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/infiniband/hw/qedr/main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index 967641662b24..10707b451ab8 100644
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -796,6 +796,7 @@ static void qedr_affiliated_event(void *context, u8 e_code, void *fw_handle)
}
xa_unlock_irqrestore(&dev->srqs, flags);
DP_NOTICE(dev, "SRQ event %d on handle %p\n", e_code, srq);
+ break;
default:
break;
}
--
2.27.0

2020-11-22 20:14:03

by Michal Kalderon

Subject: RE: [EXT] [PATCH 035/141] IB/qedr: Fix fall-through warnings for Clang

> From: Gustavo A. R. Silva <[email protected]>
> Sent: Friday, November 20, 2020 8:29 PM
>
> ----------------------------------------------------------------------
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by
> explicitly adding a break statement instead of just letting the code fall
> through to the next case.
>
> Link: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_KSPP_linux_issues_115&d=DwIBAg&c=nKjWec2b6R0mOyP
> az7xtfQ&r=5_8rRZTDuAS-6X-cGRU9Fo4yjCnkS1t7T3-
> gjL4FQng&m=ZJjyam8OGRTmM8iCzOSDOL7dMn31Pmw3aA-
> QOVDY8eg&s=4rQYW1K3xAzeRV7SRkrvaivRWz2WwEuuk0ZnjnDTA1w&e=
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/infiniband/hw/qedr/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/qedr/main.c
> b/drivers/infiniband/hw/qedr/main.c
> index 967641662b24..10707b451ab8 100644
> --- a/drivers/infiniband/hw/qedr/main.c
> +++ b/drivers/infiniband/hw/qedr/main.c
> @@ -796,6 +796,7 @@ static void qedr_affiliated_event(void *context, u8
> e_code, void *fw_handle)
> }
> xa_unlock_irqrestore(&dev->srqs, flags);
> DP_NOTICE(dev, "SRQ event %d on handle %p\n", e_code,
> srq);
> + break;
> default:
> break;
> }
> --
> 2.27.0

Thanks,?

Acked-by: Michal Kalderon?<[email protected]>

2020-11-23 22:53:21

by Gustavo A. R. Silva

Subject: Re: [EXT] [PATCH 035/141] IB/qedr: Fix fall-through warnings for Clang

On Sun, Nov 22, 2020 at 08:12:15PM +0000, Michal Kalderon wrote:
> > From: Gustavo A. R. Silva <[email protected]>
> > Sent: Friday, November 20, 2020 8:29 PM
> >
> > ----------------------------------------------------------------------
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by
> > explicitly adding a break statement instead of just letting the code fall
> > through to the next case.
> >
> > Link: https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__github.com_KSPP_linux_issues_115&d=DwIBAg&c=nKjWec2b6R0mOyP
> > az7xtfQ&r=5_8rRZTDuAS-6X-cGRU9Fo4yjCnkS1t7T3-
> > gjL4FQng&m=ZJjyam8OGRTmM8iCzOSDOL7dMn31Pmw3aA-
> > QOVDY8eg&s=4rQYW1K3xAzeRV7SRkrvaivRWz2WwEuuk0ZnjnDTA1w&e=
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
> > ---
> > drivers/infiniband/hw/qedr/main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/infiniband/hw/qedr/main.c
> > b/drivers/infiniband/hw/qedr/main.c
> > index 967641662b24..10707b451ab8 100644
> > --- a/drivers/infiniband/hw/qedr/main.c
> > +++ b/drivers/infiniband/hw/qedr/main.c
> > @@ -796,6 +796,7 @@ static void qedr_affiliated_event(void *context, u8
> > e_code, void *fw_handle)
> > }
> > xa_unlock_irqrestore(&dev->srqs, flags);
> > DP_NOTICE(dev, "SRQ event %d on handle %p\n", e_code,
> > srq);
> > + break;
> > default:
> > break;
> > }
> > --
> > 2.27.0
>
> Thanks,?
>
> Acked-by: Michal Kalderon?<[email protected]>

Thanks, Michal.
--
Gustavo