Without this symbol, the safexcel driver causes a link error:
drivers/crypto/inside-secure/safexcel_hash.o: In function `safexcel_ahash_final':
safexcel_hash.c:(.text+0x3c4): undefined reference to `sm3_zero_message_hash'
Fixes: 0f2bc13181ce ("crypto: inside-secure - Added support for basic SM3 ahash")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 357e230769c8..1ca8d9a15f2a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL
select CRYPTO_SHA512
select CRYPTO_CHACHA20POLY1305
select CRYPTO_SHA3
+ select CRYPTO_SM3
help
This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
engines designed by Inside Secure. It currently accelerates DES, 3DES and
--
2.20.0
> -----Original Message-----
> From: Arnd Bergmann <[email protected]>
> Sent: Tuesday, October 22, 2019 4:29 PM
> To: Herbert Xu <[email protected]>; David S. Miller <[email protected]>
> Cc: Arnd Bergmann <[email protected]>; Antoine Tenart <[email protected]>; Pascal Van
> Leeuwen <[email protected]>; Ard Biesheuvel <[email protected]>; Pascal van
> Leeuwen <[email protected]>; [email protected]; [email protected]
> Subject: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3
>
> Without this symbol, the safexcel driver causes a link error:
>
> drivers/crypto/inside-secure/safexcel_hash.o: In function `safexcel_ahash_final':
> safexcel_hash.c:(.text+0x3c4): undefined reference to `sm3_zero_message_hash'
>
> Fixes: 0f2bc13181ce ("crypto: inside-secure - Added support for basic SM3 ahash")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 357e230769c8..1ca8d9a15f2a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL
> select CRYPTO_SHA512
> select CRYPTO_CHACHA20POLY1305
> select CRYPTO_SHA3
> + select CRYPTO_SM3
>
Was this problem observed with the latest state of the Cryptodev GIT?
Because I already attempted to fix this issue with commit 99a59da3723b9725
Can you please double check if you still get the compile error with that
commit included?
(I can't tell from this mail which version of the sources you are using)
> help
> This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
> engines designed by Inside Secure. It currently accelerates DES, 3DES and
> --
> 2.20.0
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
http://www.insidesecure.com
On Tue, Oct 22, 2019 at 5:42 PM Pascal Van Leeuwen
<[email protected]> wrote:
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index 357e230769c8..1ca8d9a15f2a 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL
> > select CRYPTO_SHA512
> > select CRYPTO_CHACHA20POLY1305
> > select CRYPTO_SHA3
> > + select CRYPTO_SM3
> >
> Was this problem observed with the latest state of the Cryptodev GIT?
> Because I already attempted to fix this issue with commit 99a59da3723b9725
> Can you please double check if you still get the compile error with that
> commit included?
> (I can't tell from this mail which version of the sources you are using)
I was testing on linux-5.4-rc3 plus some of my own patches, so your fix
was not included.
With your patch applied, mine is no longer needed.
Arnd