2020-07-19 00:28:49

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] ACPI: actypes.h: drop a duplicated word

Drop the repeated word "an" in a comment.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Len Brown <[email protected]>
Cc: [email protected]
---
include/acpi/actypes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200717.orig/include/acpi/actypes.h
+++ linux-next-20200717/include/acpi/actypes.h
@@ -824,7 +824,7 @@ typedef u8 acpi_adr_space_type;
*
* Note: A Data Table region is a special type of operation region
* that has its own AML opcode. However, internally, the AML
- * interpreter simply creates an operation region with an an address
+ * interpreter simply creates an operation region with an address
* space type of ACPI_ADR_SPACE_DATA_TABLE.
*/
#define ACPI_ADR_SPACE_DATA_TABLE (acpi_adr_space_type) 0x7E /* Internal to ACPICA only */


2020-07-27 12:45:59

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: actypes.h: drop a duplicated word

On Sun, Jul 19, 2020 at 2:27 AM Randy Dunlap <[email protected]> wrote:
>
> Drop the repeated word "an" in a comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: [email protected]
> ---
> include/acpi/actypes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200717.orig/include/acpi/actypes.h
> +++ linux-next-20200717/include/acpi/actypes.h
> @@ -824,7 +824,7 @@ typedef u8 acpi_adr_space_type;
> *
> * Note: A Data Table region is a special type of operation region
> * that has its own AML opcode. However, internally, the AML
> - * interpreter simply creates an operation region with an an address
> + * interpreter simply creates an operation region with an address
> * space type of ACPI_ADR_SPACE_DATA_TABLE.
> */
> #define ACPI_ADR_SPACE_DATA_TABLE (acpi_adr_space_type) 0x7E /* Internal to ACPICA only */

This is an ACPICA header file, so it's better to route the change
through the upstream.

Erik, can you pick up this one, please?

2020-07-27 18:53:11

by Kaneda, Erik

[permalink] [raw]
Subject: RE: [PATCH] ACPI: actypes.h: drop a duplicated word



> -----Original Message-----
> From: Rafael J. Wysocki <[email protected]>
> Sent: Monday, July 27, 2020 5:44 AM
> To: Randy Dunlap <[email protected]>; Kaneda, Erik
> <[email protected]>
> Cc: Linux Kernel Mailing List <[email protected]>; Rafael J.
> Wysocki <[email protected]>; Len Brown <[email protected]>; ACPI Devel
> Maling List <[email protected]>; Moore, Robert
> <[email protected]>
> Subject: Re: [PATCH] ACPI: actypes.h: drop a duplicated word
>
> On Sun, Jul 19, 2020 at 2:27 AM Randy Dunlap <[email protected]>
> wrote:
> >
> > Drop the repeated word "an" in a comment.
> >
> > Signed-off-by: Randy Dunlap <[email protected]>
> > Cc: "Rafael J. Wysocki" <[email protected]>
> > Cc: Len Brown <[email protected]>
> > Cc: [email protected]
> > ---
> > include/acpi/actypes.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-next-20200717.orig/include/acpi/actypes.h
> > +++ linux-next-20200717/include/acpi/actypes.h
> > @@ -824,7 +824,7 @@ typedef u8 acpi_adr_space_type;
> > *
> > * Note: A Data Table region is a special type of operation region
> > * that has its own AML opcode. However, internally, the AML
> > - * interpreter simply creates an operation region with an an address
> > + * interpreter simply creates an operation region with an address
> > * space type of ACPI_ADR_SPACE_DATA_TABLE.
> > */
> > #define ACPI_ADR_SPACE_DATA_TABLE (acpi_adr_space_type) 0x7E
> /* Internal to ACPICA only */
>
> This is an ACPICA header file, so it's better to route the change
> through the upstream.
>
> Erik, can you pick up this one, please?

Done.

I made a pull request here: https://github.com/acpica/acpica/pull/618
It will be in the next ACPICA release.

Thanks!
Erik