2016-10-24 07:34:17

by Borislav Petkov

[permalink] [raw]
Subject: radeon_connector_unregister NULL ptr deref

Hi guys,

I'm getting a NULL ptr deref splat when hibernating my box with
4.9-rc1+. All I got so far is an ugly camera shot from the splat which
I'm typing in by hand.

Any ideas or already a fix?

The callstack looks like this:

unable to handle kernel NULL pointer dereference at 00...0890 (I think it is 890)
IP: radeon_connector_unregister+0xc/0x40
...

? drm_connector_unregister.part
drm_connector_unregister_all
drm_modeset_unregister_all
drm_dev_unregister
drm_put_dev
radeon_pci_shutdown
pci_device_shutdown
device_shutdown
kernel_power_off
power_down
hibernate
...

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.


2016-10-24 07:52:16

by Michel Dänzer

[permalink] [raw]
Subject: Re: radeon_connector_unregister NULL ptr deref

On 24/10/16 04:34 PM, Borislav Petkov wrote:
> Hi guys,
>
> I'm getting a NULL ptr deref splat when hibernating my box with
> 4.9-rc1+. All I got so far is an ugly camera shot from the splat which
> I'm typing in by hand.
>
> Any ideas or already a fix?
>
> The callstack looks like this:
>
> unable to handle kernel NULL pointer dereference at 00...0890 (I think it is 890)
> IP: radeon_connector_unregister+0xc/0x40
> ...
>
> ? drm_connector_unregister.part
> drm_connector_unregister_all
> drm_modeset_unregister_all
> drm_dev_unregister
> drm_put_dev
> radeon_pci_shutdown
> pci_device_shutdown
> device_shutdown
> kernel_power_off
> power_down
> hibernate
> ...

Should be fixed in -rc2, specifically these commits:

https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5
https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=9305ee6fe52035f63d70d023235b792ba22107f0


--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer

2016-10-24 08:19:17

by Borislav Petkov

[permalink] [raw]
Subject: Re: radeon_connector_unregister NULL ptr deref

On Mon, Oct 24, 2016 at 04:46:30PM +0900, Michel Dänzer wrote:
> Should be fixed in -rc2, specifically these commits:
>
> https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5
> https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=9305ee6fe52035f63d70d023235b792ba22107f0

Thanks but just tried rc2. Exactly the same splat :-(

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--

2016-10-24 14:55:31

by Deucher, Alexander

[permalink] [raw]
Subject: RE: radeon_connector_unregister NULL ptr deref

> -----Original Message-----
> From: Borislav Petkov [mailto:[email protected]]
> Sent: Monday, October 24, 2016 4:19 AM
> To: Michel Dänzer
> Cc: Deucher, Alexander; Koenig, Christian; lkml; dri-
> [email protected]
> Subject: Re: radeon_connector_unregister NULL ptr deref
>
> On Mon, Oct 24, 2016 at 04:46:30PM +0900, Michel Dänzer wrote:
> > Should be fixed in -rc2, specifically these commits:
> >
> > https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-
> next&id=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5
> > https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-
> next&id=9305ee6fe52035f63d70d023235b792ba22107f0
>
> Thanks but just tried rc2. Exactly the same splat :-(

It was working in drm-next. It appears something regressed in the meantime. See kernel bug 178421.

Alex

>
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --

2016-10-24 15:59:26

by Borislav Petkov

[permalink] [raw]
Subject: Re: radeon_connector_unregister NULL ptr deref

On Mon, Oct 24, 2016 at 02:55:26PM +0000, Deucher, Alexander wrote:
> It was working in drm-next. It appears something regressed in the
> meantime. See kernel bug 178421.

Thanks Alex, I've added myself to CC.

Ping me if you need me to test patches or need more debugging info.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.