2023-09-29 07:37:58

by Ratheesh Kannoth

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH net] octeontx2-pf: Fix page pool frag allocation failure.

> From: Yunsheng Lin <[email protected]>
> Subject: [EXT] Re: [PATCH net] octeontx2-pf: Fix page pool frag allocation
> failure.
>


> If I understand it correctly, it is not a crash, but a warning as the requsted size
> is bigger than PAGE_SIZE for order 0, so the below checking triggered the
> warning, right?
Yes. Will change commit message ( s/crash/warn)


> > + sz = ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN),
> PAGE_SIZE);
> > + pp_params.order = (sz / PAGE_SIZE) - 1;
>
> Perhaps use PAGE_ALIGN() and get_order() for the above?
ACK

-Ratheesh