Hi James,
After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is larger than 2048 bytes [-Wframe-larger-than=]
}
^
Introduced by commit
0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of ring buffer to write")
--
Cheers,
Stephen Rothwell
> Subject: linux-next: build warning after merge of the scsi tree
>
> Hi James,
>
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
> drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is
> larger than 2048 bytes [-Wframe-larger-than=] } ^
>
> Introduced by commit
>
> 0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of
> ring buffer to write")
Thanks for catching this. This is due to the size of struct cpumask is too big, when CONFIG_NR_CPUS=8192 is used in most kernel config.
I will fix this by moving those data structure to kmalloc pre-allocated when channel is first created.
>
> --
> Cheers,
> Stephen Rothwell
Long,
> I will fix this by moving those data structure to kmalloc pre-allocated
> when channel is first created.
Sounds good. I'll drop patch 3 for now and wait for you to resubmit.
--
Martin K. Petersen Oracle Linux Engineering
Hi all,
On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/target/target_core_base.h:7:0,
> from drivers/target/target_core_tmr.c:31:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
> ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
> ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
> ^~~~~~~~
> In file included from include/target/target_core_base.h:7:0,
> from drivers/target/target_core_ua.c:30:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
> ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
> ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
> ^~~~~~~~
>
> Introduced by commit
>
> 24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>
> in v4.11.rc1, but exposed by commit
>
> eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
I am still seeing these warnings ...
--
Cheers,
Stephen Rothwell
On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <[email protected]> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>> from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>> ^~~~~~~~
>> In file included from include/target/target_core_base.h:7:0,
>> from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>> ^~~~~~~~
>>
>> Introduced by commit
>>
>> 24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>> eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
>
> I am still seeing these warnings ...
Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.
--
Jens Axboe
On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
[...]
> > I am still seeing these warnings ...
>
> Martin queued up the forward declaration patch for this one, not sure
> why it isn't showing up in the scsi tree yet.
All the trees are fully up to date ... which commit is it?
James
On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
> On 7/10/18 8:14 AM, James Bottomley wrote:
> > On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> > > On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> >
> > [...]
> > > > I am still seeing these warnings ...
> > >
> > > Martin queued up the forward declaration patch for this one, not
> > > sure
> > > why it isn't showing up in the scsi tree yet.
> >
> > All the trees are fully up to date ... which commit is it?
>
> It's a patch from Arnd, I don't know what commit id it is. But
> Martin replied a few days ago that it was applied. I don't have
> the email handy, though.
You mean
Message-Id: <[email protected]>
Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration
?
Martin didn't reply and it's not yet in his tree, although I'm sure it
will be soon.
James
On 7/10/18 8:26 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
>> On 7/10/18 8:14 AM, James Bottomley wrote:
>>> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>>>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
>>>
>>> [...]
>>>>> I am still seeing these warnings ...
>>>>
>>>> Martin queued up the forward declaration patch for this one, not
>>>> sure
>>>> why it isn't showing up in the scsi tree yet.
>>>
>>> All the trees are fully up to date ... which commit is it?
>>
>> It's a patch from Arnd, I don't know what commit id it is. But
>> Martin replied a few days ago that it was applied. I don't have
>> the email handy, though.
>
> You mean
>
> Message-Id: <[email protected]>
> Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration
>
> ?
>
> Martin didn't reply and it's not yet in his tree, although I'm sure it
> will be soon.
Yeah that's the one. I now had to look it up, looks like I mixed it up
with the host busy patch from Ming.
We should get it applied. Feel free to add my reviewed-by, if you want.
--
Jens Axboe
Jens,
>> Message-Id: <[email protected]>
>> Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration
>> Martin didn't reply and it's not yet in his tree, although I'm sure it
>> will be soon.
Been out on vacation. I thought I committed it but I guess not. I'll get
to it today.
--
Martin K. Petersen Oracle Linux Engineering
On 7/10/18 8:14 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> [...]
>>> I am still seeing these warnings ...
>>
>> Martin queued up the forward declaration patch for this one, not sure
>> why it isn't showing up in the scsi tree yet.
>
> All the trees are fully up to date ... which commit is it?
It's a patch from Arnd, I don't know what commit id it is. But
Martin replied a few days ago that it was applied. I don't have
the email handy, though.
--
Jens Axboe