2017-11-13 16:10:02

by Matthew Wilcox

[permalink] [raw]
Subject: RE: [PATCH] radix-tree: replace <linux/spinlock.h> with <linux/spinlock_types.h>

It's a waste of time. I have the XArray replacement well in hand, so this header isn't staying around long-term.

> -----Original Message-----
> From: Masahiro Yamada [mailto:[email protected]]
> Sent: Sunday, November 12, 2017 11:43 PM
> To: Andrew Morton <[email protected]>
> Cc: Masahiro Yamada <[email protected]>; Matthew Wilcox
> <[email protected]>; Jan Kara <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; Johannes Weiner <[email protected]>;
> Chris Mi <[email protected]>
> Subject: Re: [PATCH] radix-tree: replace <linux/spinlock.h> with
> <linux/spinlock_types.h>
>
> Hi Andrew,
>
>
> 2017-10-13 22:03 GMT+09:00 Masahiro Yamada
> <[email protected]>:
> > This header contains references to spinlock_t and lockdep_is_held(),
> > both of which are defined in <linux/spinlock_types.h>
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
>
>
> I have not got any comment on this patch.
>
> Could you take a look at it, please?
>
>
> > ---
> >
> > include/linux/radix-tree.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
> > index 567ebb5..6df7fa9 100644
> > --- a/include/linux/radix-tree.h
> > +++ b/include/linux/radix-tree.h
> > @@ -27,7 +27,7 @@
> > #include <linux/list.h>
> > #include <linux/preempt.h>
> > #include <linux/rcupdate.h>
> > -#include <linux/spinlock.h>
> > +#include <linux/spinlock_types.h>
> > #include <linux/types.h>
> >
> > /*
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
?&ן7?n:筴?9?_??L?sh?]???8?m??M4?M{_???1? ????u㾹??u?m?ߕ?f????m?l??ۣ?jנ???????????+?ƥRz