2024-05-16 16:17:28

by Souradeep Chakrabarti

Subject: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request

Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
This patch fixes that.

Cc: [email protected]
Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
Signed-off-by: Souradeep Chakrabarti <[email protected]>
---
drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index 2729a2c5acf9..ca814fe8a775 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -848,7 +848,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
}

if (!wait_for_completion_timeout(&ctx->comp_event,
- (msecs_to_jiffies(hwc->hwc_timeout) * HZ))) {
+ (msecs_to_jiffies(hwc->hwc_timeout)))) {
dev_err(hwc->dev, "HWC: Request timed out!\n");
err = -ETIMEDOUT;
goto out;
--
2.34.1

2024-05-16 16:47:55

by Dexuan Cui

Subject: RE: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request

> From: Souradeep Chakrabarti <[email protected]>
> Sent: Thursday, May 16, 2024 9:06 AM
> ...
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: [email protected]
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <[email protected]>
> ---
Looks good to me.
Reviewed-by: Dexuan Cui <[email protected]>

2024-05-16 16:54:23

by Brett Creeley

Subject: Re: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request

On 5/16/2024 9:05 AM, Souradeep Chakrabarti wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: [email protected]
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <[email protected]>
> ---
> drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

LGTM.

Reviewed-by: Brett Creeley <[email protected]>

2024-05-16 17:19:16

by Andrew Lunn

Subject: Re: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request

On Thu, May 16, 2024 at 09:05:38AM -0700, Souradeep Chakrabarti wrote:
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: [email protected]
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <[email protected]>

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Please set the Subject line to [PATCH net] to indicate which tree this
applies to.

Andrew