2019-10-08 16:16:34

by Tiezhu Yang

Subject: [PATCH v2] MIPS: generic: Use __initconst for const init data

Fix the following checkpatch errors:

$ ./scripts/checkpatch.pl --no-tree -f arch/mips/generic/init.c
ERROR: Use of const init definition must use __initconst
#23: FILE: arch/mips/generic/init.c:23:
+static __initdata const void *fdt;

ERROR: Use of const init definition must use __initconst
#24: FILE: arch/mips/generic/init.c:24:
+static __initdata const struct mips_machine *mach;

ERROR: Use of const init definition must use __initconst
#25: FILE: arch/mips/generic/init.c:25:
+static __initdata const void *mach_match_data;

Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
Signed-off-by: Tiezhu Yang <[email protected]>
---

v2: update the commit message and use the 'Fixes:' tag

arch/mips/generic/init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c
index d5b8c47..1de215b 100644
--- a/arch/mips/generic/init.c
+++ b/arch/mips/generic/init.c
@@ -20,9 +20,9 @@
#include <asm/smp-ops.h>
#include <asm/time.h>

-static __initdata const void *fdt;
-static __initdata const struct mips_machine *mach;
-static __initdata const void *mach_match_data;
+static __initconst const void *fdt;
+static __initconst const struct mips_machine *mach;
+static __initconst const void *mach_match_data;

void __init prom_init(void)
{
--
2.1.0

2019-10-08 17:56:25

by Paul Burton

Subject: Re: [PATCH v2] MIPS: generic: Use __initconst for const init data

Hello,

Tiezhu Yang wrote:
> Fix the following checkpatch errors:
>
> $ ./scripts/checkpatch.pl --no-tree -f arch/mips/generic/init.c
> ERROR: Use of const init definition must use __initconst
> #23: FILE: arch/mips/generic/init.c:23:
> +static __initdata const void *fdt;
>
> ERROR: Use of const init definition must use __initconst
> #24: FILE: arch/mips/generic/init.c:24:
> +static __initdata const struct mips_machine *mach;
>
> ERROR: Use of const init definition must use __initconst
> #25: FILE: arch/mips/generic/init.c:25:
> +static __initdata const void *mach_match_data;

Applied to mips-next.

> commit a14bf1dc494a
> https://git.kernel.org/mips/c/a14bf1dc494a
>
> Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Tiezhu Yang <[email protected]>
> Signed-off-by: Paul Burton <[email protected]>

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]