2019-09-10 10:41:53

by Christophe JAILLET

Subject: [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()'

'exit' functions should be marked as __exit, not __init.

Fixes: 85cc028817ef ("mips: make loongsoon serial driver explicitly modular")
Signed-off-by: Christophe JAILLET <[email protected]>
---
arch/mips/loongson64/common/serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson64/common/serial.c b/arch/mips/loongson64/common/serial.c
index ffefc1cb2612..98c3a7feb10f 100644
--- a/arch/mips/loongson64/common/serial.c
+++ b/arch/mips/loongson64/common/serial.c
@@ -110,7 +110,7 @@ static int __init serial_init(void)
}
module_init(serial_init);

-static void __init serial_exit(void)
+static void __exit serial_exit(void)
{
platform_device_unregister(&uart8250_device);
}
--
2.20.1

2019-10-03 00:30:37

by Paul Burton

Subject: Re: [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()'

Hello,

Christophe JAILLET wrote:
> 'exit' functions should be marked as __exit, not __init.

Applied to mips-fixes.

> commit 25b69a889b63
> https://git.kernel.org/mips/c/25b69a889b63
>
> Fixes: 85cc028817ef ("mips: make loongsoon serial driver explicitly modular")
> Signed-off-by: Christophe JAILLET <[email protected]>
> Signed-off-by: Paul Burton <[email protected]>

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]