2019-09-13 12:07:03

by Aurabindo Pillai

[permalink] [raw]
Subject: [PATCH] mips: check for dsp presence only once before save/restore

{save,restore}_dsp() internally checks if the cpu has dsp support.
Therefore, explicit check is not required before calling them in
{save,restore}_processor_state()

Signed-off-by: Aurabindo Jayamohanan <[email protected]>
---
arch/mips/power/cpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/power/cpu.c b/arch/mips/power/cpu.c
index 3340a5530de3..a15e29dfc7b3 100644
--- a/arch/mips/power/cpu.c
+++ b/arch/mips/power/cpu.c
@@ -19,8 +19,8 @@ void save_processor_state(void)

if (is_fpu_owner())
save_fp(current);
- if (cpu_has_dsp)
- save_dsp(current);
+
+ save_dsp(current);
}

void restore_processor_state(void)
@@ -29,8 +29,8 @@ void restore_processor_state(void)

if (is_fpu_owner())
restore_fp(current);
- if (cpu_has_dsp)
- restore_dsp(current);
+
+ restore_dsp(current);
}

int pfn_is_nosave(unsigned long pfn)
--
2.23.0



2019-10-07 17:59:53

by Paul Burton

[permalink] [raw]
Subject: Re: [PATCH] mips: check for dsp presence only once before save/restore

Hello,

Aurabindo Jayamohanan wrote:
> {save,restore}_dsp() internally checks if the cpu has dsp support.
> Therefore, explicit check is not required before calling them in
> {save,restore}_processor_state()

Applied to mips-next.

> commit 9662dd752c14
> https://git.kernel.org/mips/c/9662dd752c14
>
> Signed-off-by: Aurabindo Jayamohanan <[email protected]>
> Signed-off-by: Paul Burton <[email protected]>

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]