2002-08-30 12:46:19

by Frank Davis

[permalink] [raw]
Subject: 2.5.32 : net/ipv4/netfilter/ipfwadm_core.c compile error

Hello all,
While 'make modules', I received the following error.

Regards,
Frank

ipfwadm_core.c: In function `ip_fw_chk':
ipfwadm_core.c:450: structure has no member named `read_locked_map'
ipfwadm_core.c:450: structure has no member named `write_locked_map'
ipfwadm_core.c:450: structure has no member named `l'
ipfwadm_core.c:450: structure has no member named `read_locked_map'
ipfwadm_core.c:452: structure has no member named `read_locked_map'
ipfwadm_core.c:452: structure has no member named `write_locked_map'
ipfwadm_core.c:452: structure has no member named `l'
ipfwadm_core.c:452: structure has no member named `write_locked_map'
ipfwadm_core.c:677: structure has no member named `read_locked_map'
ipfwadm_core.c:677: structure has no member named `read_locked_map'
ipfwadm_core.c:677: structure has no member named `l'
ipfwadm_core.c:679: structure has no member named `write_locked_map'
ipfwadm_core.c:679: structure has no member named `write_locked_map'
ipfwadm_core.c:679: structure has no member named `l'
ipfwadm_core.c: In function `zero_fw_chain':
ipfwadm_core.c:689: structure has no member named `read_locked_map'
ipfwadm_core.c:689: structure has no member named `write_locked_map'
ipfwadm_core.c:689: structure has no member named `l'
ipfwadm_core.c:689: structure has no member named `write_locked_map'
ipfwadm_core.c:696: structure has no member named `write_locked_map'
ipfwadm_core.c:696: structure has no member named `write_locked_map'
ipfwadm_core.c:696: structure has no member named `l'
ipfwadm_core.c: In function `free_fw_chain':
ipfwadm_core.c:701: structure has no member named `read_locked_map'
ipfwadm_core.c:701: structure has no member named `write_locked_map'
ipfwadm_core.c:701: structure has no member named `l'
ipfwadm_core.c:701: structure has no member named `write_locked_map'
ipfwadm_core.c:710: structure has no member named `write_locked_map'
ipfwadm_core.c:710: structure has no member named `write_locked_map'
ipfwadm_core.c:710: structure has no member named `l'
ipfwadm_core.c: In function `insert_in_chain':
ipfwadm_core.c:738: structure has no member named `read_locked_map'
ipfwadm_core.c:738: structure has no member named `write_locked_map'
ipfwadm_core.c:738: structure has no member named `l'
ipfwadm_core.c:738: structure has no member named `write_locked_map'
ipfwadm_core.c:748: structure has no member named `write_locked_map'
ipfwadm_core.c:748: structure has no member named `write_locked_map'
ipfwadm_core.c:748: structure has no member named `l'
ipfwadm_core.c: In function `append_to_chain':
ipfwadm_core.c:780: structure has no member named `read_locked_map'
ipfwadm_core.c:780: structure has no member named `write_locked_map'
ipfwadm_core.c:780: structure has no member named `l'
ipfwadm_core.c:780: structure has no member named `write_locked_map'
ipfwadm_core.c:796: structure has no member named `write_locked_map'
ipfwadm_core.c:796: structure has no member named `write_locked_map'
ipfwadm_core.c:796: structure has no member named `l'
ipfwadm_core.c: In function `del_from_chain':
ipfwadm_core.c:807: structure has no member named `read_locked_map'
ipfwadm_core.c:807: structure has no member named `write_locked_map'
ipfwadm_core.c:807: structure has no member named `l'
ipfwadm_core.c:807: structure has no member named `write_locked_map'
ipfwadm_core.c:816: structure has no member named `write_locked_map'
ipfwadm_core.c:816: structure has no member named `write_locked_map'
ipfwadm_core.c:816: structure has no member named `l'
ipfwadm_core.c:868: structure has no member named `write_locked_map'
ipfwadm_core.c:868: structure has no member named `write_locked_map'
ipfwadm_core.c:868: structure has no member named `l'
ipfwadm_core.c: In function `ip_chain_procinfo':
ipfwadm_core.c:1158: structure has no member named `read_locked_map'
ipfwadm_core.c:1158: structure has no member named `write_locked_map'
ipfwadm_core.c:1158: structure has no member named `l'
ipfwadm_core.c:1158: structure has no member named `read_locked_map'
ipfwadm_core.c:1199: structure has no member named `read_locked_map'
ipfwadm_core.c:1199: structure has no member named `read_locked_map'
ipfwadm_core.c:1199: structure has no member named `l'
ipfwadm_core.c: In function `ipfw_device_event':
ipfwadm_core.c:1345: structure has no member named `read_locked_map'
ipfwadm_core.c:1345: structure has no member named `write_locked_map'
ipfwadm_core.c:1345: structure has no member named `l'
ipfwadm_core.c:1345: structure has no member named `write_locked_map'
ipfwadm_core.c:1362: structure has no member named `write_locked_map'
ipfwadm_core.c:1362: structure has no member named `write_locked_map'
ipfwadm_core.c:1362: structure has no member named `l'
make[3]: *** [ipfwadm_core.o] Error 1
make[3]: Leaving directory `/usr/src/linux/net/ipv4/netfilter'
make[2]: *** [netfilter] Error 2
make[2]: Leaving directory `/usr/src/linux/net/ipv4'
make[1]: *** [ipv4] Error 2
make[1]: Leaving directory `/usr/src/linux/net'
make: *** [net] Error 2


2002-09-01 03:14:15

by James Morris

[permalink] [raw]
Subject: [PATCH] Re: 2.5.32 : net/ipv4/netfilter/ipfwadm_core.c compile error

On Fri, 30 Aug 2002, Frank Davis wrote:

> Hello all,
> While 'make modules', I received the following error.
>
> Regards,
> Frank
>
> ipfwadm_core.c: In function `ip_fw_chk':
> ipfwadm_core.c:450: structure has no member named `read_locked_map'
> ipfwadm_core.c:450: structure has no member named `write_locked_map'

Please see the fix below. (The problem only shows up when netfilter
debugging is enabled).


- James
--
James Morris
<[email protected]>

diff -urN -X dontdiff linux-2.5.33.w1/net/ipv4/netfilter/ipfwadm_core.c linux-2.5.33.w1-ipfwadm/net/ipv4/netfilter/ipfwadm_core.c
--- linux-2.5.33.w1/net/ipv4/netfilter/ipfwadm_core.c Wed Aug 28 13:24:30 2002
+++ linux-2.5.33.w1-ipfwadm/net/ipv4/netfilter/ipfwadm_core.c Sun Sep 1 12:16:16 2002
@@ -156,7 +156,7 @@
#define dprint_ip(a)
#endif

-static rwlock_t ip_fw_lock = RW_LOCK_UNLOCKED;
+static DECLARE_RWLOCK(ip_fw_lock);

#if defined(CONFIG_IP_ACCT) || defined(CONFIG_IP_FIREWALL)



2002-09-01 06:06:48

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] Re: 2.5.32 : net/ipv4/netfilter/ipfwadm_core.c compile error

From: James Morris <[email protected]>
Date: Sun, 1 Sep 2002 13:18:32 +1000 (EST)

Please see the fix below. (The problem only shows up when netfilter
debugging is enabled).

Applied to my tree, thanks.