2021-12-25 14:07:18

by David Heidelberg

Subject: [PATCH] dt-bindings: mfd: syscon: Add Qualcomm TCSR registers

Qualcomm devices have a set of registers that provide various control and status
functions for their peripherals.

Modification:
- dropped "qcom,tcsr-ipq6018", "syscon", "simple-mfd", since it's not
used anywhere.

Signed-off-by: David Heidelberg <[email protected]>
---
.../devicetree/bindings/mfd/qcom,tcsr.txt | 23 -------------------
.../devicetree/bindings/mfd/syscon.yaml | 8 +++++++
2 files changed, 8 insertions(+), 23 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,tcsr.txt

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.txt b/Documentation/devicetree/bindings/mfd/qcom,tcsr.txt
deleted file mode 100644
index c5f4f0ddfcc3..000000000000
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-QCOM Top Control and Status Register
-
-Qualcomm devices have a set of registers that provide various control and status
-functions for their peripherals. This node is intended to allow access to these
-registers via syscon.
-
-Required properties:
-- compatible: Should contain:
- "qcom,tcsr-ipq6018", "syscon", "simple-mfd" for IPQ6018
- "qcom,tcsr-ipq8064", "syscon" for IPQ8064
- "qcom,tcsr-apq8064", "syscon" for APQ8064
- "qcom,tcsr-msm8660", "syscon" for MSM8660
- "qcom,tcsr-msm8960", "syscon" for MSM8960
- "qcom,tcsr-msm8974", "syscon" for MSM8974
- "qcom,tcsr-apq8084", "syscon" for APQ8084
- "qcom,tcsr-msm8916", "syscon" for MSM8916
-- reg: Address range for TCSR registers
-
-Example:
- tcsr: syscon@1a400000 {
- compatible = "qcom,tcsr-msm8960", "syscon";
- reg = <0x1a400000 0x100>;
- };
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index eeac1cbc5a17..6d6058b694e7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -60,6 +60,14 @@ properties:
- samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
+ - qcom,tcsr-apq8064
+ - qcom,tcsr-apq8084
+ - qcom,tcsr-ipq6018
+ - qcom,tcsr-ipq8064
+ - qcom,tcsr-msm8660
+ - qcom,tcsr-msm8916
+ - qcom,tcsr-msm8960
+ - qcom,tcsr-msm8974

- const: syscon

--
2.34.1

2022-01-04 22:16:10

by Rob Herring

Subject: Re: [PATCH] dt-bindings: mfd: syscon: Add Qualcomm TCSR registers

On Sat, Dec 25, 2021 at 03:07:07PM +0100, David Heidelberg wrote:
> Qualcomm devices have a set of registers that provide various control and status
> functions for their peripherals.
>
> Modification:
> - dropped "qcom,tcsr-ipq6018", "syscon", "simple-mfd", since it's not
> used anywhere.

There is about to be. See:
https://lore.kernel.org/all/b5053b42f73e574f48cf860a8e225d6b1939d216.1639499239.git.baruch@tkos.co.il/

2022-01-08 18:56:58

by David Heidelberg

Subject: Re: [PATCH] dt-bindings: mfd: syscon: Add Qualcomm TCSR registers

Should I go path specifying MFD or though I could just add minItems: 2
and maxItems: 4 to the list?

What you think Rob?
David

On Tue, Jan 4 2022 at 16:16:06 -0600, Rob Herring <[email protected]>
wrote:
> On Sat, Dec 25, 2021 at 03:07:07PM +0100, David Heidelberg wrote:
>> Qualcomm devices have a set of registers that provide various
>> control and status
>> functions for their peripherals.
>>
>> Modification:
>> - dropped "qcom,tcsr-ipq6018", "syscon", "simple-mfd", since it's
>> not
>> used anywhere.
>
> There is about to be. See:
> https://lore.kernel.org/all/b5053b42f73e574f48cf860a8e225d6b1939d216.1639499239.git.baruch@tkos.co.il/