2021-12-02 10:08:15

by Jiapeng Chong

Subject: [PATCH] RDMA/siw: Use max() instead of doing it manually

Fix following coccicheck warning:

./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING opportunity
for max().

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
index d15a1f9..a3dd2cb 100644
--- a/drivers/infiniband/sw/siw/siw_verbs.c
+++ b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct ib_send_wr *core_wr,
kbuf += core_sge->length;
core_sge++;
}
- sqe->sge[0].length = bytes > 0 ? bytes : 0;
+ sqe->sge[0].length = max(bytes, 0);
sqe->num_sge = bytes > 0 ? 1 : 0;

return bytes;
--
1.8.3.1

2021-12-02 12:07:24

by Bernard Metzler

Subject: Re: [PATCH] RDMA/siw: Use max() instead of doing it manually

-----"Jiapeng Chong" <[email protected]> wrote: -----

>To: [email protected]
>From: "Jiapeng Chong" <[email protected]>
>Date: 12/02/2021 11:08AM
>Cc: [email protected], [email protected],
>[email protected], "Jiapeng Chong"
><[email protected]>
>Subject: [EXTERNAL] [PATCH] RDMA/siw: Use max() instead of doing it
>manually
>
>Fix following coccicheck warning:
>
>./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING
>opportunity
>for max().
>
>Reported-by: Abaci Robot <[email protected]>
>Signed-off-by: Jiapeng Chong <[email protected]>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index d15a1f9..a3dd2cb 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct
>ib_send_wr *core_wr,
> kbuf += core_sge->length;
> core_sge++;
> }
>- sqe->sge[0].length = bytes > 0 ? bytes : 0;
>+ sqe->sge[0].length = max(bytes, 0);
> sqe->num_sge = bytes > 0 ? 1 : 0;
>
> return bytes;
>--
>1.8.3.1
>
>
Looks good, thanks!

Reviewed-by: Bernard Metzler <[email protected]>

2021-12-06 23:52:08

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/siw: Use max() instead of doing it manually

On Thu, Dec 02, 2021 at 06:07:59PM +0800, Jiapeng Chong wrote:
> Fix following coccicheck warning:
>
> ./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING opportunity
> for max().
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> Reviewed-by: Bernard Metzler <[email protected]>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason