Robert Olsson wrote..
>In slab terms you moved part of the destructor to the constructor
>but the main problem is still there. The skb entered the "wrong" CPU
>so to be "reused from the slab again" the work has to done regardless
>if it's in the constructor or destructor.
That is true if it is a uni processor but in smp the initialization,
if happened in two different CPUs, affects performance due to cache
effects.
The problem of object (skb) allocation, usage and deallocation occurring
in multiple CPUs need to be addressed separately. This patch is not
attempting to address that.
>Eventually if we accept some cache misses a skb could possibly be
re-routed
>to the proper slab/CPU for this we would need some skb coloring.
You still can do this. I don't see skbinit patch hindering this.
Regards,
Mala
Mala Anand
IBM Linux Technology Center - Kernel Performance
E-mail:[email protected]
http://www-124.ibm.com/developerworks/opensource/linuxperf
http://www-124.ibm.com/developerworks/projects/linuxperf
Phone:838-8088; Tie-line:678-8088