2009-09-14 02:13:12

by Chen Liqin

[permalink] [raw]
Subject: [GIT PULL, v4] S+core architecture (arch/score) support

Hi Linus,

We had setup a git server at gitserver.sunplusct.com,
This repository contains Linux support for S+core CPU.
it's base on Linux 2.6.31-rc7 and Arnd asm-generic repository.

please pull:
git pull git://gitserver.sunplusct.com/linux-2.6-score.git
for-linus

Changes in v4:
Sending pull request again.

Changes in v3:
With the help of Arnd and Roland.

Changes in v2:
Christoph Hellwig and Arnd review it.

Thanks,
Liqin

-----


2009-09-17 16:32:14

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL, v4] S+core architecture (arch/score) support



On Mon, 14 Sep 2009, [email protected] wrote:
>
> We had setup a git server at gitserver.sunplusct.com,
> This repository contains Linux support for S+core CPU.
> it's base on Linux 2.6.31-rc7 and Arnd asm-generic repository.
>
> please pull:
> git pull git://gitserver.sunplusct.com/linux-2.6-score.git
> for-linus
>
> Changes in v4:
> Sending pull request again.
>
> Changes in v3:
> With the help of Arnd and Roland.
>
> Changes in v2:
> Christoph Hellwig and Arnd review it.

I want to see a proper pull request with diffstats etc (and the branch
name on the same line etc). I realize I can just pull and look at what I
get, but that's not how I work. I want to know that what I get is also
what you expected to send to me, and perhaps equally importantly, I want
to know that you know how to work with me in the future.

Linus

2009-09-18 04:37:53

by Chen Liqin

[permalink] [raw]
Subject: Re: [GIT PULL, v4] S+core architecture (arch/score) support

Linus Torvalds <[email protected]> д?? 2009-09-18 00:31:36:
>
> I want to see a proper pull request with diffstats etc (and the branch
> name on the same line etc).

OK, I will send the pull request again.

> I realize I can just pull and look at what I
> get, but that's not how I work. I want to know that what I get is also
> what you expected to send to me, and perhaps equally importantly, I want

> to know that you know how to work with me in the future.
>

Hi Linus,
We have a team to maintain the linux/score relative code.
Now we really don't know your working rules, like when we fix
the score code, when to send the pull request to you again,
and etc.

Would you please give me some advice, or tell me where
to get these informations, that will be helpful for us to co-work
with you in the future.

Best Regards
Liqin
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?

2009-09-18 04:37:10

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL, v4] S+core architecture (arch/score) support



On Fri, 18 Sep 2009, [email protected] wrote:
>
> Would you please give me some advice, or tell me where
> to get these informations, that will be helpful for us to co-work
> with you in the future.

See all the other pull requests out there. Some of them are scripted (by
fairly trivial scripts), some of them are done by hand, but they tend to
all have the same structure: a 'shortlog' of the commits that are new, and
a diffstat (with summary) of the changes.

The important thing is that then I know what to expect from the pull,
rather than having to pull blindly and see the end result (without really
knowing whether that was what you intended for me to get).

There's even a 'git request-pull' script that comes with git that
generates these things, although I'm not sure how many people use that
particular script.

But just look for "please pull" on lkml, and you'll find a lot of
examples.

Btw, I appreciate people not sending just the raw unedited "git
request-pull" output. I'd like people to actually look at it to make sure
that the thing matches what you expected, but also add a few lines of your
own to describe the changes in your own words.

Linus