2001-02-05 15:44:28

by Matthew Harrell

[permalink] [raw]
Subject: 2.4.{1,2pre1} oops in via82cxxx_audio (?)


I'm not positive that's what's causing the oops but it seems to happen only
when I load the sound driver and when esd starts to send a noise to the device.
The oops and config are attached below. Let me know if it's funny looking -
I typed it in by hand after it killed the machine but it's easily reproducable.
Also, while it doesn't seem to be deterministic it happens over 90% of the time

--
Matthew Harrell If at first you don't succeed,
Bit Twiddlers, Inc. try management.
[email protected]


Attachments:
(No filename) (566.00 B)
oops-output.txt (2.38 kB)
config (21.75 kB)
Download all attachments

2001-02-05 16:02:31

by Matthew Harrell

[permalink] [raw]
Subject: Re: 2.4.{1,2pre1} oops in via82cxxx_audio (?)

: I'm not positive that's what's causing the oops but it seems to happen only
: when I load the sound driver and when esd starts to send a noise to the device.
: The oops and config are attached below. Let me know if it's funny looking -
: I typed it in by hand after it killed the machine but it's easily reproducable.
: Also, while it doesn't seem to be deterministic it happens over 90% of the time

Just realized that some of those symbols were defined in the via82cxxx_audio
module and I needed to load it to get them recognized. As long as I don't
play any sounds the module will load fine so here is the new and improved
ksymoops output

--
Matthew Harrell Behind every great computer sits
Bit Twiddlers, Inc. a skinny little geek.
[email protected]


Attachments:
(No filename) (826.00 B)
output (2.40 kB)
Download all attachments

2001-02-05 18:28:58

by Jeff Garzik

[permalink] [raw]
Subject: Re: 2.4.{1,2pre1} oops in via82cxxx_audio (?)

Index: drivers/sound/via82cxxx_audio.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/sound/via82cxxx_audio.c,v
retrieving revision 1.1.1.11.2.1
diff -u -r1.1.1.11.2.1 via82cxxx_audio.c
--- drivers/sound/via82cxxx_audio.c 2001/02/04 19:07:03 1.1.1.11.2.1
+++ drivers/sound/via82cxxx_audio.c 2001/02/05 18:24:48
@@ -1649,6 +1649,9 @@
u8 status;
int n;

+ assert (chan != NULL);
+ assert (chan->sgtable != NULL);
+
/* check pertinent bits of status register for action bits */
status = inb (chan->iobase) & (VIA_SGD_FLAG | VIA_SGD_EOL | VIA_SGD_STOPPED);
if (!status)
@@ -1728,6 +1731,8 @@
{
struct via_info *card = dev_id;
u32 status32;
+
+ assert (card != NULL);

/* to minimize interrupt sharing costs, we use the SGD status
* shadow register to check the status of all inputs and


Attachments:
via.patch (870.00 B)

2001-02-05 18:56:38

by Matthew Harrell

[permalink] [raw]
Subject: Re: 2.4.{1,2pre1} oops in via82cxxx_audio (?)

: Ouch. After applying the attached patch, do any of the assertions
: trigger? (You should get a message 'Assertion failed! ...' right before
: the oops)

: + assert (chan->sgtable != NULL);

Yep, I get this one "chan->sgtable != NULL". I have no idea what this means
but I got it one out of the two times I tried.

--
Matthew Harrell Every morning is the dawn of a
Bit Twiddlers, Inc. new error.
[email protected]

2001-02-05 20:27:56

by rui.sousa

[permalink] [raw]
Subject: Re: 2.4.{1,2pre1} oops in via82cxxx_audio (?)





On 05/02/01 20:55 Jeff Garzik wrote:

> [email protected] wrote:
> >
> > On Mon, 5 Feb 2001, Matthew Harrell wrote:
> >
> > > : Ouch. After applying the attached patch, do any of the assertions
> > > : trigger? (You should get a message 'Assertion failed! ...' right
before
> > > : the oops)
> > >
> > > : + assert (chan->sgtable != NULL);
> > >
> > > Yep, I get this one "chan->sgtable != NULL". I have no idea what
this means
> > > but I got it one out of the two times I tried.
> > >
> >
> > Is there any other device on the same irq?
>
> Yes, it looks like:
>
> Matthew Harrell wrote:
> > PCI: Found IRQ 10 for device 00:14.5
> > PCI: The same IRQ used for device 00:04.0
>
> The attached patch, sent to Matthew privately, apparently has fixed his
> problem. Right now it looks like an out-of-band interrupt... The
> interrupt is enabled via request_irq, and its shared so the interrupt
> handler will be called. However the channel isn't active so the SG
> table hasn't been allocated yet.

But your interrupt status register should indicate that it wasn't the
sound device that generated the interrupt...


Matthew, can you try the attached patched and report the output?
You should apply it on a clean 2.4.1 (without the patches Jeff sent you).
Try only sound playback.

Rui Sousa


(See attached file: patch)


Attachments:
patch (706.00 B)

2001-02-05 20:35:20

by Jeff Garzik

[permalink] [raw]
Subject: Re: 2.4.{1,2pre1} oops in via82cxxx_audio (?)

[email protected] wrote:
> On 05/02/01 20:55 Jeff Garzik wrote:
> > The attached patch, sent to Matthew privately, apparently has fixed his
> > problem. Right now it looks like an out-of-band interrupt... The
> > interrupt is enabled via request_irq, and its shared so the interrupt
> > handler will be called. However the channel isn't active so the SG
> > table hasn't been allocated yet.
>
> But your interrupt status register should indicate that it wasn't the
> sound device that generated the interrupt...

Agreed -- iobase is uninitalized, I believe.

--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie