2007-08-24 19:09:54

by Laurent Vivier

[permalink] [raw]
Subject: Réf. : Re: [PATCH] export i386 smp_call _function _mask () to modules


> On Fri, 24 Aug 2007 17:36:35 +0200
> Laurent Vivier <[email protected]> wrote:
>
> > This patch export i386 smp_call_function_mask() with EXPORT_SYMBOL().
> >
> > This function is needed by KVM to call a function on a set of CPUs.
> >
> > arch/i386/kernel/smp.c | 7 +++++++
> > include/asm-i386/smp.h | 9 +++------
> > 2 files changed, 10 insertions(+), 6 deletions(-)
> >
> > Signed-off-by: Laurent Vivier <[email protected]>
>
> hmm isn't it being an inline also making it available for KVM to use?
> If so... isn't your patch description entirely not matching what the
> code does?

It is available for KVM compilation, not for KVM use.

In fact smp_ops is not available for KVM use, so as
smp_call_function_mask() is smp_ops.smp_call_function_mask() we can say it
is not available...

My first reflex was to export smp_ops, but as it seems it is an internal
and hidden variable, it appears I should export smp_call_function_mask()
instead.

Laurent