2003-02-25 17:54:04

by Bastian Blank

Subject: [PATCH] s390 - dasd with devfs

hi folks

this patch fixes s390 dasd with devfs

bastian

diff -ru linux-2.5.63.orig/drivers/s390/block/dasd.c linux-2.5.63/drivers/s390/block/dasd.c
--- linux-2.5.63.orig/drivers/s390/block/dasd.c 2003-02-24 20:05:31.000000000 +0100
+++ linux-2.5.63/drivers/s390/block/dasd.c 2003-02-25 18:51:34.000000000 +0100
@@ -2077,7 +2077,7 @@

DBF_EVENT(DBF_EMERG, "%s", "debug area created");

- if (devfs_mk_dir(NULL, "dasd", NULL)) {
+ if (!devfs_mk_dir(NULL, "dasd", NULL)) {
DBF_EVENT(DBF_ALERT, "%s", "no devfs");
rc = -ENOSYS;
goto failed;

--
Men of peace usually are [brave].
-- Spock, "The Savage Curtain", stardate 5906.5

2003-02-25 18:40:51

by Bastian Blank

Subject: Re: [PATCH] s390 - dasd with devfs

On Tue, Feb 25, 2003 at 07:04:13PM +0100, Bastian Blank wrote:
> this patch fixes s390 dasd with devfs

if forgot a fix and include an updated patch

bastian

diff -ur linux-2.5.63.orig/drivers/s390/block/dasd.c linux-2.5.63/drivers/s390/block/dasd.c
--- linux-2.5.63.orig/drivers/s390/block/dasd.c 2003-02-24 20:05:31.000000000 +0100
+++ linux-2.5.63/drivers/s390/block/dasd.c 2003-02-25 18:51:34.000000000 +0100
@@ -2077,7 +2077,7 @@

DBF_EVENT(DBF_EMERG, "%s", "debug area created");

- if (devfs_mk_dir(NULL, "dasd", NULL)) {
+ if (!devfs_mk_dir(NULL, "dasd", NULL)) {
DBF_EVENT(DBF_ALERT, "%s", "no devfs");
rc = -ENOSYS;
goto failed;
diff -ur linux-2.5.63.orig/drivers/s390/block/dasd_genhd.c linux-2.5.63/drivers/s390/block/dasd_genhd.c
--- linux-2.5.63.orig/drivers/s390/block/dasd_genhd.c 2003-02-24 20:05:39.000000000 +0100
+++ linux-2.5.63/drivers/s390/block/dasd_genhd.c 2003-02-25 19:47:27.000000000 +0100
@@ -145,6 +145,7 @@
gdp->major = mi->major;
gdp->first_minor = index << DASD_PARTN_BITS;
gdp->fops = &dasd_device_operations;
+ gdp->flags |= GENHD_FL_DEVFS;

/*
* Set device name.
--
You're dead, Jim.
-- McCoy, "The Tholian Web", stardate unknown

2003-02-28 09:34:07

by Martin Schwidefsky

Subject: Re: [PATCH] s390 - dasd with devfs

> > this patch fixes s390 dasd with devfs
>
> if forgot a fix and include an updated patch

Added this version of the fix to our internal CVS.
It will be included in the next update.

Thanks & blue skies,
Martin