2021-12-15 10:26:04

by Heiner Kallweit

Subject: [PATCH] reset: renesas: Check return value of reset_control_deassert()

Deasserting the reset is vital, therefore bail out in case of error.

Suggested-by: Biju Das <[email protected]>
Signed-off-by: Heiner Kallweit <[email protected]>
---
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
index 1e8315038..a8dde4606 100644
--- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
+++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
@@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(priv->rstc),
"failed to get reset\n");

- reset_control_deassert(priv->rstc);
+ error = reset_control_deassert(priv->rstc);
+ if (error)
+ return error;

priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
priv->rcdev.of_reset_n_cells = 1;
--
2.34.1

2021-12-15 10:30:11

by Biju Das

Subject: RE: [PATCH] reset: renesas: Check return value of reset_control_deassert()

Hi Heiner,

Thanks for the patch

> Subject: [PATCH] reset: renesas: Check return value of
> reset_control_deassert()
>
> Deasserting the reset is vital, therefore bail out in case of error.
>
> Suggested-by: Biju Das <[email protected]>
> Signed-off-by: Heiner Kallweit <[email protected]>

Reviewed-by: Biju Das <[email protected]>

Cheers,
Biju

> ---
> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> index 1e8315038..a8dde4606 100644
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct
> platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->rstc),
> "failed to get reset\n");
>
> - reset_control_deassert(priv->rstc);
> + error = reset_control_deassert(priv->rstc);
> + if (error)
> + return error;
>
> priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
> priv->rcdev.of_reset_n_cells = 1;
> --
> 2.34.1

2021-12-15 12:18:07

by Philipp Zabel

Subject: Re: [PATCH] reset: renesas: Check return value of reset_control_deassert()

On Wed, 2021-12-15 at 11:25 +0100, Heiner Kallweit wrote:
> Deasserting the reset is vital, therefore bail out in case of error.
>
> Suggested-by: Biju Das <[email protected]>
> Signed-off-by: Heiner Kallweit <[email protected]>

Thank you, applied to reset/next.

regards
Philipp