On Tue, 26 Apr 2022 15:32:53 -0400 Min Li wrote:
> Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY
> for gettime and settime exclusively
Does not build on 32 bit.
> -/*
> +/**
> * Maximum absolute value for write phase offset in picoseconds
> *
> + * @channel: channel
> + * @delta_ns: delta in nanoseconds
> + *
Not a proper kdoc, first line must include struct name or function name.
Please wait 24h with reposting fixed version so other feedback has a
chance to come in.
> On Tue, 26 Apr 2022 15:32:53 -0400 Min Li wrote:
> > Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY for
> gettime
> > and settime exclusively
>
> Does not build on 32 bit.
>
Hi Jakub
I compiled with arm-linux-gnueabi-
By 32 bit, did you mean x86?
Min
On Wed, 27 Apr 2022 14:32:03 +0000 Min Li wrote:
> > On Tue, 26 Apr 2022 15:32:53 -0400 Min Li wrote:
> > > Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY for
> > gettime
> > > and settime exclusively
> >
> > Does not build on 32 bit.
> >
>
> Hi Jakub
>
> I compiled with arm-linux-gnueabi-
>
> By 32 bit, did you mean x86?
Yup! I think arm does not have the 64b division problems x86 has.
We hit the dreaded
ERROR: modpost: "__divdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!
ERROR: modpost: "__udivdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!
on 32b x86 builds. Sorry for lack of clarity.