2022-09-15 09:52:56

by Jens Hillenstedt

Subject: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.

In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J
register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe
of da9061 fails:

da9062 2-0058: Entering I2C mode!
da9062 2-0058: Failed to set Two-Wire Bus Mode.
da9062: probe of 2-0058 failed with error -5

Add CONFIG_J register to da9061_aa_writeable_ranges[].

Fixes: 5c6f0f456351 ("mfd: da9062: Support SMBus and I2C mode")
Signed-off-by: Jens Hillenstedt <[email protected]>
---
drivers/mfd/da9062-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
index 2774b2cbaea6..c2acdbcd5d6b 100644
--- a/drivers/mfd/da9062-core.c
+++ b/drivers/mfd/da9062-core.c
@@ -453,6 +453,7 @@ static const struct regmap_range da9061_aa_writeable_ranges[] = {
regmap_reg_range(DA9062AA_VBUCK1_B, DA9062AA_VBUCK4_B),
regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
+ regmap_reg_range(DA9062AA_CONFIG_J, DA9062AA_CONFIG_J),
regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
};

--
2.30.2

2022-09-15 15:00:37

by DLG Adam Ward

Subject: RE: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.

On 15 September 2022 10:20 Jens Hillenstedt wrote:
>In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe of da9061 fails:

Thanks!
Reviewed-by: Adam Ward <[email protected]>

2022-09-28 10:50:59

by Lee Jones

Subject: Re: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.

On Thu, 15 Sep 2022, Jens Hillenstedt wrote:

> In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J
> register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe
> of da9061 fails:
>
> da9062 2-0058: Entering I2C mode!
> da9062 2-0058: Failed to set Two-Wire Bus Mode.
> da9062: probe of 2-0058 failed with error -5
>
> Add CONFIG_J register to da9061_aa_writeable_ranges[].
>
> Fixes: 5c6f0f456351 ("mfd: da9062: Support SMBus and I2C mode")
> Signed-off-by: Jens Hillenstedt <[email protected]>
> ---
> drivers/mfd/da9062-core.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]