2018-07-09 21:57:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the pinctrl tree

Hi Linus,

Commit

a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")

is missing a Signed-off-by from its author.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-07-09 22:47:57

by Linus Walleij

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

Hm must have come from Geert's pull request?

(I'm regularly wrong about this so not so certain...)

Geert can I fix it the usual way by simply rebasing and
adding the right SoB?

Yours,
Linus Walleij

On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi Linus,
>
> Commit
>
> a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell

2018-07-10 01:20:13

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: linux-next: Signed-off-by missing for commit in the pinctrl tree

Hi Stephen, Linus, Geert,

> -----Original Message-----
> From: Linus Walleij, Sent: Tuesday, July 10, 2018 7:46 AM
>
> Hm must have come from Geert's pull request?
>
> (I'm regularly wrong about this so not so certain...)
>
> Geert can I fix it the usual way by simply rebasing and
> adding the right SoB?

I'm very sorry for this trouble.
When I ported this patch, I dropped the author's Signed-of-by wrongly..

Signed-off-by: Takeshi Kihara <[email protected]>

Best regards,
Yoshihiro Shimoda

> Yours,
> Linus Walleij
>
> On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi Linus,
> >
> > Commit
> >
> > a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> >
> > is missing a Signed-off-by from its author.
> >
> > --
> > Cheers,
> > Stephen Rothwell

2018-07-10 07:08:26

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

Hi Shimoda-san, Linus,

On Tue, Jul 10, 2018 at 3:18 AM Yoshihiro Shimoda
<[email protected]> wrote:
> > -----Original Message-----
> > From: Linus Walleij, Sent: Tuesday, July 10, 2018 7:46 AM
> >
> > Hm must have come from Geert's pull request?
> >
> > (I'm regularly wrong about this so not so certain...)
> >
> > Geert can I fix it the usual way by simply rebasing and
> > adding the right SoB?
>
> I'm very sorry for this trouble.
> When I ported this patch, I dropped the author's Signed-of-by wrongly..
>
> Signed-off-by: Takeshi Kihara <[email protected]>

Thank you!

Since this was the top commit from my last pull request, I've just ammended it,
retagged, and pushed.

Sorry for the trouble.

/me looks into improving checkpatch.pl...

> > On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <[email protected]> wrote:
> > > Commit
> > >
> > > a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> > >
> > > is missing a Signed-off-by from its author.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds