Add support for the camera daughter board which is connected to
iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
ethernet1 interfaces.
Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Marian-Cristian Rotariu <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 94 +++++++++++++++++++++++++
2 files changed, 95 insertions(+)
create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ed3376c..118e35c 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -918,6 +918,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \
r8a73a4-ape6evm.dtb \
r8a7740-armadillo800eva.dtb \
r8a7742-iwg21d-q7.dtb \
+ r8a7742-iwg21d-q7-dbcm-ca.dtb \
r8a7743-iwg20d-q7.dtb \
r8a7743-iwg20d-q7-dbcm-ca.dtb \
r8a7743-sk-rzg1m.dtb \
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
new file mode 100644
index 0000000..857aab5
--- /dev/null
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -0,0 +1,94 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the iWave-RZ/G1H Qseven board development
+ * platform with camera daughter board
+ *
+ * Copyright (C) 2020 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+#include "r8a7742-iwg21d-q7.dts"
+
+/ {
+ model = "iWave Systems RZ/G1H Qseven development platform with camera add-on";
+ compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742";
+
+ aliases {
+ serial0 = &scif0;
+ serial1 = &scif1;
+ serial3 = &scifb1;
+ serial5 = &hscif0;
+ ethernet1 = ðer;
+ };
+};
+
+&avb {
+ /* Pins shared with VIN0, keep status disabled */
+ status = "disabled";
+};
+
+ðer {
+ pinctrl-0 = <ðer_pins>;
+ pinctrl-names = "default";
+
+ phy-handle = <&phy1>;
+ renesas,ether-link-active-low;
+ status = "okay";
+
+ phy1: ethernet-phy@1 {
+ reg = <1>;
+ micrel,led-mode = <1>;
+ };
+};
+
+&hscif0 {
+ pinctrl-0 = <&hscif0_pins>;
+ pinctrl-names = "default";
+ uart-has-rtscts;
+ status = "okay";
+};
+
+&pfc {
+ ether_pins: ether {
+ groups = "eth_mdio", "eth_rmii";
+ function = "eth";
+ };
+
+ hscif0_pins: hscif0 {
+ groups = "hscif0_data", "hscif0_ctrl";
+ function = "hscif0";
+ };
+
+ scif0_pins: scif0 {
+ groups = "scif0_data";
+ function = "scif0";
+ };
+
+ scif1_pins: scif1 {
+ groups = "scif1_data";
+ function = "scif1";
+ };
+
+ scifb1_pins: scifb1 {
+ groups = "scifb1_data";
+ function = "scifb1";
+ };
+};
+
+&scif0 {
+ pinctrl-0 = <&scif0_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&scif1 {
+ pinctrl-0 = <&scif1_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&scifb1 {
+ pinctrl-0 = <&scifb1_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
--
2.7.4
Hi Prabhakar,
On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
<[email protected]> wrote:
> Add support for the camera daughter board which is connected to
> iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> ethernet1 interfaces.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Marian-Cristian Rotariu <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> +&scifb1 {
> + pinctrl-0 = <&scifb1_pins>;
> + pinctrl-names = "default";
> + status = "okay";
Before I queue this in renesas-devel for v5.9, I have on question:
As this port carries RTS/CTS signals, perhaps you want to add
rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
Thank you for the review.
On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Prabhakar,
>
> On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> <[email protected]> wrote:
> > Add support for the camera daughter board which is connected to
> > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > ethernet1 interfaces.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > Reviewed-by: Marian-Cristian Rotariu <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
>
> > +&scifb1 {
> > + pinctrl-0 = <&scifb1_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
>
> Before I queue this in renesas-devel for v5.9, I have on question:
> As this port carries RTS/CTS signals, perhaps you want to add
>
> rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
> cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
>
Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
this with the above which disproves the Doc. Shall I post it as a
separate patch or post a v2 including it.
Cheers,
--Prabhakar
> ?
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Hi Prabhakar,
On Sun, Jun 7, 2020 at 6:19 PM Lad, Prabhakar
<[email protected]> wrote:
> On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <[email protected]> wrote:
> > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> > <[email protected]> wrote:
> > > Add support for the camera daughter board which is connected to
> > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > > ethernet1 interfaces.
> > >
> > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > Reviewed-by: Marian-Cristian Rotariu <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
> >
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> >
> > > +&scifb1 {
> > > + pinctrl-0 = <&scifb1_pins>;
> > > + pinctrl-names = "default";
> > > + status = "okay";
> >
> > Before I queue this in renesas-devel for v5.9, I have on question:
> > As this port carries RTS/CTS signals, perhaps you want to add
> >
> > rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
> > cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> >
> Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
> this with the above which disproves the Doc. Shall I post it as a
RTS/CTS are indeed not connected to the dedicated RTS/CTS pins of
SCIFB1, so the documentation is right.
However, the pins on the serial port connector can be used as GPIOs,
hence they can be used with software-controlled RTS/CTS.
> separate patch or post a v2 including it.
Up to you, I can handle both.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 07 June 2020 18:42
> To: Lad, Prabhakar <[email protected]>
> Cc: Prabhakar Mahadev Lad <[email protected]>; Rob Herring <[email protected]>; Magnus Damm
> <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; Linux
> Kernel Mailing List <[email protected]>; Linux-Renesas <[email protected]>
> Subject: Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
>
> Hi Prabhakar,
>
> On Sun, Jun 7, 2020 at 6:19 PM Lad, Prabhakar
> <[email protected]> wrote:
> > On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <[email protected]> wrote:
> > > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> > > <[email protected]> wrote:
> > > > Add support for the camera daughter board which is connected to
> > > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > > > ethernet1 interfaces.
> > > >
> > > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > > Reviewed-by: Marian-Cristian Rotariu <[email protected]>
> > >
> > > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > >
> > > > --- /dev/null
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > >
> > > > +&scifb1 {
> > > > + pinctrl-0 = <&scifb1_pins>;
> > > > + pinctrl-names = "default";
> > > > + status = "okay";
> > >
> > > Before I queue this in renesas-devel for v5.9, I have on question:
> > > As this port carries RTS/CTS signals, perhaps you want to add
> > >
> > > rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
> > > cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > >
> > Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
> > this with the above which disproves the Doc. Shall I post it as a
>
> RTS/CTS are indeed not connected to the dedicated RTS/CTS pins of
> SCIFB1, so the documentation is right.
> However, the pins on the serial port connector can be used as GPIOs,
> hence they can be used with software-controlled RTS/CTS.
>
> > separate patch or post a v2 including it.
>
> Up to you, I can handle both.
>
I shall post a v2.
Cheers,
--Prabhakar
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647