2023-05-08 14:50:00

by Teoh Ji Sheng

[permalink] [raw]
Subject: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
support") introduced ethtool per-queue statistics support to display
number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
This patch extend the support to XGMAC core.

Signed-off-by: Teoh Ji Sheng <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index dfd53264e036..070bd912580b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -368,10 +368,12 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,

if (likely(intr_status & XGMAC_RI)) {
x->rx_normal_irq_n++;
+ x->rxq_stats[chan].rx_normal_irq_n++;
ret |= handle_rx;
}
if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
x->tx_normal_irq_n++;
+ x->txq_stats[chan].tx_normal_irq_n++;
ret |= handle_tx;
}
}
--
2.34.1


2023-05-08 15:30:09

by Peppe CAVALLARO

[permalink] [raw]
Subject: RE: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Hello

Idea behind the patch looks ok for me

Regards
peppe


ST Restricted

-----Original Message-----
From: Teoh Ji Sheng <[email protected]>
Sent: Monday, May 8, 2023 4:44 PM
To: David S . Miller <[email protected]>; Peppe CAVALLARO <[email protected]>; Alexandre TORGUE - foss <[email protected]>; Jose Abreu <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Maxime Coquelin <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Teoh Ji Sheng <[email protected]>
Subject: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
support") introduced ethtool per-queue statistics support to display number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
This patch extend the support to XGMAC core.

Signed-off-by: Teoh Ji Sheng <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index dfd53264e036..070bd912580b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -368,10 +368,12 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,

if (likely(intr_status & XGMAC_RI)) {
x->rx_normal_irq_n++;
+ x->rxq_stats[chan].rx_normal_irq_n++;
ret |= handle_rx;
}
if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
x->tx_normal_irq_n++;
+ x->txq_stats[chan].tx_normal_irq_n++;
ret |= handle_tx;
}
}
--
2.34.1

2023-05-08 19:56:39

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

On Mon, May 08, 2023 at 10:43:40PM +0800, Teoh Ji Sheng wrote:
> Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
> support") introduced ethtool per-queue statistics support to display
> number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
> This patch extend the support to XGMAC core.
>
> Signed-off-by: Teoh Ji Sheng <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-05-10 03:27:41

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 8 May 2023 22:43:40 +0800 you wrote:
> Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
> support") introduced ethtool per-queue statistics support to display
> number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
> This patch extend the support to XGMAC core.
>
> Signed-off-by: Teoh Ji Sheng <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support
https://git.kernel.org/netdev/net-next/c/af8eacf2b42e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html