Hi,
> -----Original Message-----
> From: Cosmin Tanislav <[email protected]>
> Sent: Thursday, October 28, 2021 3:56 PM
> Cc: [email protected]; Tanislav, Cosmin
> <[email protected]>; Lars-Peter Clausen
> <[email protected]>; Hennerich, Michael
> <[email protected]>; Jonathan Cameron
> <[email protected]>; Rob Herring <[email protected]>; linux-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH v2 1/3] iio: add adddac subdirectory
>
> [External]
>
> From: Cosmin Tanislav <[email protected]>
>
> For IIO devices that expose both ADC and DAC functionality.
>
> Signed-off-by: Cosmin Tanislav <[email protected]>
> ---
One thing here that I'm not too sure is the naming of the directory.
I'm starting to see in ADI more and more of this highly integrated devices... For
example this one [1], is something we have someone already working one
and it has ADCs, DAC, amplifiers. So, I'm just wondering if now
it's not the time where we just have a generic enough place for these kind
of "combo" devices? Being that said, I have no idea about what name we could
give :)
[1]: https://www.analog.com/media/en/technical-documentation/data-sheets/AD7293.pdf
- Nuno S?
On Fri, 29 Oct 2021 08:00:05 +0000
"Sa, Nuno" <[email protected]> wrote:
> Hi,
>
> > -----Original Message-----
> > From: Cosmin Tanislav <[email protected]>
> > Sent: Thursday, October 28, 2021 3:56 PM
> > Cc: [email protected]; Tanislav, Cosmin
> > <[email protected]>; Lars-Peter Clausen
> > <[email protected]>; Hennerich, Michael
> > <[email protected]>; Jonathan Cameron
> > <[email protected]>; Rob Herring <[email protected]>; linux-
> > [email protected]; [email protected]; linux-
> > [email protected]
> > Subject: [PATCH v2 1/3] iio: add adddac subdirectory
> >
> > [External]
> >
> > From: Cosmin Tanislav <[email protected]>
> >
> > For IIO devices that expose both ADC and DAC functionality.
> >
> > Signed-off-by: Cosmin Tanislav <[email protected]>
> > ---
>
> One thing here that I'm not too sure is the naming of the directory.
> I'm starting to see in ADI more and more of this highly integrated devices... For
> example this one [1], is something we have someone already working one
> and it has ADCs, DAC, amplifiers. So, I'm just wondering if now
> it's not the time where we just have a generic enough place for these kind
> of "combo" devices? Being that said, I have no idea about what name we could
> give :)
>
> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/AD7293.pdf
> - Nuno Sá
Naming is always fun. I don't want to have combo start picking up IMUs so
we need to be a bit careful.
We could take the approach we have done with proximity and light sensors of effectively
declaring one type to the dominant one. There it's a bit clearer though - you don't
buy a proximity sensor if you want to just measure light levels.
Here there isn't always a dominant type. The example here is titled input / output
device so no preference of one over the other. The GPIO stuff is kind of a feature
bolted on, so ADDAC is generic enough.
For the ad7293 it does call it a Power Amplifiers 'with' the other stuff so maybe
just sticking to amplifier as the type is the way to go.
Meh, to a certain extent it doesn't matter - we can safely move these around
once we have more of them in the tree. The adt7316 is still in staging and
is an ADDAC as well so I think we should put that category in for now.
Jonathan
>
>