2022-04-01 19:00:09

by Nuno Sa

[permalink] [raw]
Subject: RE: [PATCH 3/3] iio: sysfs-trigger: replace usage of found with dedicated list iterator variable



> -----Original Message-----
> From: Jakob Koschel <[email protected]>
> Sent: Friday, April 1, 2022 1:07 AM
> To: Jonathan Cameron <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>; Dan Carpenter
> <[email protected]>; Jakob Koschel
> <[email protected]>; [email protected]; linux-
> [email protected]; Mike Rapoport <[email protected]>; Brian
> Johannesmeyer <[email protected]>; Cristiano Giuffrida
> <[email protected]>; Bos, H.J. <[email protected]>
> Subject: [PATCH 3/3] iio: sysfs-trigger: replace usage of found with
> dedicated list iterator variable
>
> [External]
>
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CAHk-
> =wgRr_D8CB-D9Kg-
> [email protected]/__;!!A3Ni8CS0y
> 2Y!q8mEciLiCAWjMGEwW9jHDD2DoeaKzrMwtUcRCNAZ0gW9DPBVtJk
> xR5FMPPCJNw$ [1]
> Signed-off-by: Jakob Koschel <[email protected]>
> ---

Reviewed-by: Nuno S? <[email protected]>