2023-04-06 01:45:39

by Song, Yoong Siang

Subject: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function

Queue reset was moved out from __init_dma_rx_desc_rings() and
__init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit
and receive packet after XDP prog setup.

This commit adds the missing queue reset into stmmac_xdp_open() function.

v2: Add reviewed-by tag

Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions")
Cc: <[email protected]> # 6.0+
Reviewed-by: Alexander Duyck <[email protected]>
Signed-off-by: Song Yoong Siang <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 3e5bbfe3c41b..e4c27eb17bd2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev)
goto init_error;
}

+ stmmac_reset_queues_param(priv);
+
/* DMA CSR Channel configuration */
for (chan = 0; chan < dma_csr_ch; chan++) {
stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan);
--
2.34.1

2023-04-06 02:16:49

by Jakub Kicinski

Subject: Re: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function

On Thu, 6 Apr 2023 09:40:04 +0800 Song Yoong Siang wrote:
> v2: Add reviewed-by tag

You don't have to repost to add tags, maintainers will collect
the tags sent to the list when applying the patch. I'm taking v1.

2023-04-06 15:00:40

by Song, Yoong Siang

Subject: RE: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function

>On Thu, 6 Apr 2023 09:40:04 +0800 Song Yoong Siang wrote:
>> v2: Add reviewed-by tag
>
>You don't have to repost to add tags, maintainers will collect the tags sent to the
>list when applying the patch. I'm taking v1.

Noted. Thanks.