On 29/09/2023 15:37, Linu Cherian wrote:
> memory-region 0: Reserved trace buffer memory
>
> TMC ETR: When available, use this reserved memory region for
> trace data capture. Same region is used for trace data
> retention after a panic or watchdog reset.
>
> TMC ETF: When available, use this reserved memory region for
> trace data retention synced from internal SRAM after a panic or
> watchdog reset.
>
> memory-region 1: Reserved meta data memory
>
> TMC ETR, ETF: When available, use this memory for register
> snapshot retention synced from hardware registers after a panic
> or watchdog reset.
>
> Signed-off-by: Linu Cherian <[email protected]>
> ---
Where is the changelog? This is supposed to be v4 or something later.
Please, keep proper versioning and changelog.
> .../bindings/arm/arm,coresight-tmc.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> index cb8dceaca70e..45ca4d02d73e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> @@ -101,6 +101,22 @@ properties:
> and ETF configurations.
> $ref: /schemas/graph.yaml#/properties/port
>
> + memory-region:
> + items:
> + - description: Reserved trace buffer memory for ETR and ETF sinks.
> + For ETR, this reserved memory region is used for trace data capture.
> + Same region is used for trace data retention as well after a panic
> + or watchdog reset.
> + For ETF, this reserved memory region is used for retention of trace
> + data synced from internal SRAM after a panic or watchdog reset.
> +
> + - description: Reserved meta data memory. Used for ETR and ETF sinks.
> +
> + memory-region-names:
> + items:
> + - const: trace-mem
> + - const: metadata-mem
Drop the 'mem' suffixes.
Best regards,
Krzysztof
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Saturday, September 30, 2023 8:59 PM
> To: Linu Cherian <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Sunil Kovvuri Goutham
> <[email protected]>; George Cherian <[email protected]>
> Subject: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
> "memory-region" property
>
> External Email
>
> ----------------------------------------------------------------------
> On 29/09/2023 15:37, Linu Cherian wrote:
> > memory-region 0: Reserved trace buffer memory
> >
> > TMC ETR: When available, use this reserved memory region for
> > trace data capture. Same region is used for trace data
> > retention after a panic or watchdog reset.
> >
> > TMC ETF: When available, use this reserved memory region for
> > trace data retention synced from internal SRAM after a panic or
> > watchdog reset.
> >
> > memory-region 1: Reserved meta data memory
> >
> > TMC ETR, ETF: When available, use this memory for register
> > snapshot retention synced from hardware registers after a panic
> > or watchdog reset.
> >
> > Signed-off-by: Linu Cherian <[email protected]>
> > ---
>
> Where is the changelog? This is supposed to be v4 or something later.
> Please, keep proper versioning and changelog.
Sure, will add the changelog from next version onwards.
Yeah, the last version was RFC v3 and the RFC tag has been dropped from this version onwards.
Hence started this version with V1.
>
> > .../bindings/arm/arm,coresight-tmc.yaml | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-
> tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-
> tmc.yaml
> > index cb8dceaca70e..45ca4d02d73e 100644
> > --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> > @@ -101,6 +101,22 @@ properties:
> > and ETF configurations.
> > $ref: /schemas/graph.yaml#/properties/port
> >
> > + memory-region:
> > + items:
> > + - description: Reserved trace buffer memory for ETR and ETF sinks.
> > + For ETR, this reserved memory region is used for trace data capture.
> > + Same region is used for trace data retention as well after a panic
> > + or watchdog reset.
> > + For ETF, this reserved memory region is used for retention of trace
> > + data synced from internal SRAM after a panic or watchdog reset.
> > +
> > + - description: Reserved meta data memory. Used for ETR and ETF sinks.
> > +
> > + memory-region-names:
> > + items:
> > + - const: trace-mem
> > + - const: metadata-mem
>
> Drop the 'mem' suffixes.
>
Ack. Will remove it in next version.
On 03/10/2023 06:33, Linu Cherian wrote:
> Hi Krzysztof,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <[email protected]>
>> Sent: Saturday, September 30, 2023 8:59 PM
>> To: Linu Cherian <[email protected]>; [email protected];
>> [email protected]; [email protected]; [email protected]
>> Cc: [email protected]; [email protected]; linux-
>> [email protected]; [email protected];
>> [email protected]; [email protected];
>> [email protected]; Sunil Kovvuri Goutham
>> <[email protected]>; George Cherian <[email protected]>
>> Subject: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
>> "memory-region" property
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 29/09/2023 15:37, Linu Cherian wrote:
>>> memory-region 0: Reserved trace buffer memory
>>>
>>> TMC ETR: When available, use this reserved memory region for
>>> trace data capture. Same region is used for trace data
>>> retention after a panic or watchdog reset.
>>>
>>> TMC ETF: When available, use this reserved memory region for
>>> trace data retention synced from internal SRAM after a panic or
>>> watchdog reset.
>>>
>>> memory-region 1: Reserved meta data memory
>>>
>>> TMC ETR, ETF: When available, use this memory for register
>>> snapshot retention synced from hardware registers after a panic
>>> or watchdog reset.
>>>
>>> Signed-off-by: Linu Cherian <[email protected]>
>>> ---
>>
>> Where is the changelog? This is supposed to be v4 or something later.
>> Please, keep proper versioning and changelog.
>
> Sure, will add the changelog from next version onwards.
>
> Yeah, the last version was RFC v3 and the RFC tag has been dropped from this version onwards.
> Hence started this version with V1.
v1 says it is the first version, but you already had three others.
Please keep continuous version log, regardless whether you call it RFC
or RFT or RFsomething.
>
>>
>>> .../bindings/arm/arm,coresight-tmc.yaml | 19 +++++++++++++++++++
>>> 1 file changed, 19 insertions(+)
>>>
Best regards,
Krzysztof
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Tuesday, October 3, 2023 12:02 PM
> To: Linu Cherian <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Sunil Kovvuri Goutham
> <[email protected]>; George Cherian <[email protected]>
> Subject: Re: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
> "memory-region" property
>
> On 03/10/2023 06:33, Linu Cherian wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <[email protected]>
> >> Sent: Saturday, September 30, 2023 8:59 PM
> >> To: Linu Cherian <[email protected]>; [email protected];
> >> [email protected]; [email protected]; [email protected]
> >> Cc: [email protected]; [email protected];
> >> linux- [email protected]; [email protected];
> >> [email protected]; [email protected];
> >> [email protected]; Sunil Kovvuri Goutham
> >> <[email protected]>; George Cherian <[email protected]>
> >> Subject: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
> >> "memory-region" property
> >>
> >> External Email
> >>
> >> ---------------------------------------------------------------------
> >> - On 29/09/2023 15:37, Linu Cherian wrote:
> >>> memory-region 0: Reserved trace buffer memory
> >>>
> >>> TMC ETR: When available, use this reserved memory region for
> >>> trace data capture. Same region is used for trace data
> >>> retention after a panic or watchdog reset.
> >>>
> >>> TMC ETF: When available, use this reserved memory region for
> >>> trace data retention synced from internal SRAM after a panic or
> >>> watchdog reset.
> >>>
> >>> memory-region 1: Reserved meta data memory
> >>>
> >>> TMC ETR, ETF: When available, use this memory for register
> >>> snapshot retention synced from hardware registers after a panic
> >>> or watchdog reset.
> >>>
> >>> Signed-off-by: Linu Cherian <[email protected]>
> >>> ---
> >>
> >> Where is the changelog? This is supposed to be v4 or something later.
> >> Please, keep proper versioning and changelog.
> >
> > Sure, will add the changelog from next version onwards.
> >
> > Yeah, the last version was RFC v3 and the RFC tag has been dropped from
> this version onwards.
> > Hence started this version with V1.
>
> v1 says it is the first version, but you already had three others.
> Please keep continuous version log, regardless whether you call it RFC or RFT
> or RFsomething.
Okay. Will continue with Patch V5 from next series and add necessary notes in cover letter.
>
> >
> >>
> >>> .../bindings/arm/arm,coresight-tmc.yaml | 19
> +++++++++++++++++++
> >>> 1 file changed, 19 insertions(+)
> >>>
>
> Best regards,
> Krzysztof