2024-03-13 12:41:50

by FLAVIO SULIGOI

Subject: [PATCH] thermal: qoriq: remove redundant TMTMIR_DEFAULT

The definition of TMTMIR_DEFAULT is repeated two times in the code.
The first time is useless.
It makes more sense to leave this definition after the correspondent
REGS_TMTMIR register definition:

Signed-off-by: Flavio Suligoi <[email protected]>
---
drivers/thermal/qoriq_thermal.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index ccc2eea7f9f5..c29ed179c12d 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -20,7 +20,6 @@
#define TMR_ME 0x80000000
#define TMR_ALPF 0x0c000000
#define TMR_ALPF_V2 0x03000000
-#define TMTMIR_DEFAULT 0x0000000f
#define TIER_DISABLE 0x0
#define TEUMR0_V2 0x51009c00
#define TMSARA_V2 0xe
--
2.34.1

2024-03-13 13:45:26

by FLAVIO SULIGOI

Subject: RE: EXTERNAL: [PATCH] thermal: qoriq: remove redundant TMTMIR_DEFAULT

Hi all,

..
> The definition of TMTMIR_DEFAULT is repeated two times in the code.
> The first time is useless.
> It makes more sense to leave this definition after the correspondent
> REGS_TMTMIR register definition:
>
> Signed-off-by: Flavio Suligoi <[email protected]>

there are also other double macro definitions, such as:

TMR_DISABLE
TMR_ME
TMR_ALPF
TIER_DISABLE

Would you like me to put some order?

regards,
Flavio