2023-11-30 18:47:12

by Min Li

[permalink] [raw]
Subject: [PATCH net-next v6 3/6] ptp: clockmatrix: Fix u8 -> u16, DPLL_WF_TIMER and DPLL_WP_TIMER are 2-byte registers

From: Min Li <[email protected]>

Signed-off-by: Min Li <[email protected]>
---
drivers/ptp/ptp_clockmatrix.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index 6d55da54e496..d069b6e451ef 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -1396,18 +1396,18 @@ static int idtcm_set_pll_mode(struct idtcm_channel *channel,
struct idtcm *idtcm = channel->idtcm;
int err;
u8 dpll_mode;
- u8 timeout = 0;
+ u8 buf[2] = {0};

/* Setup WF/WP timer for phase pull-in to work correctly */
err = idtcm_write(idtcm, channel->dpll_n, DPLL_WF_TIMER,
- &timeout, sizeof(timeout));
+ buf, sizeof(buf));
if (err)
return err;

if (mode == PLL_MODE_WRITE_PHASE)
- timeout = 160;
+ buf[0] = 160;
err = idtcm_write(idtcm, channel->dpll_n, DPLL_WP_TIMER,
- &timeout, sizeof(timeout));
+ buf, sizeof(buf));
if (err)
return err;

--
2.39.2


2023-12-05 02:45:01

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net-next v6 3/6] ptp: clockmatrix: Fix u8 -> u16, DPLL_WF_TIMER and DPLL_WP_TIMER are 2-byte registers

On Thu, 30 Nov 2023 13:46:31 -0500 Min Li wrote:
> Subject: [PATCH net-next v6 3/6] ptp: clockmatrix: Fix u8 -> u16, DPLL_WF_TIMER and DPLL_WP_TIMER are 2-byte registers

> From: Min Li <[email protected]>

Thanks for the changes, much easier to review now.
This patch, however, should be squashed with the previous one.